From: Guenter Roeck <linux@roeck-us.net>
To: Hoan Tran <hotran@apm.com>, Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Itaru Kitayama <itaru.kitayama@riken.jp>,
lho@apm.com, Duc Dang <dhdang@apm.com>
Subject: Re: [PATCH v3] hwmon: xgene: Fix crash when alarm occurs before driver probe
Date: Thu, 8 Sep 2016 21:25:39 -0700 [thread overview]
Message-ID: <35107ad4-b0f3-4d12-4650-4e7656ed66ea@roeck-us.net> (raw)
In-Reply-To: <1473352390-30781-1-git-send-email-hotran@apm.com>
On 09/08/2016 09:33 AM, Hoan Tran wrote:
> The system crashes during probing xgene-hwmon driver when temperature
> alarm interrupt occurs before.
> It's because
> - xgene_hwmon_probe() requests mailbox channel which also enables
> the mailbox interrupt.
> - As temperature alarm interrupt is pending, ISR runs and crashes when accesses
> into invalid resourse as unmapped PCC shared memory.
>
> This patch fixes this issue by saving this alarm message and scheduling a
> bottom handler after xgene_hwmon_probe() finish.
>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> Reported-by: Itaru Kitayama <itaru.kitayama@riken.jp>
> ---
Applied to -next.
Thanks,
Guenter
prev parent reply other threads:[~2016-09-09 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 16:33 [PATCH v3] hwmon: xgene: Fix crash when alarm occurs before driver probe Hoan Tran
2016-09-09 4:25 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35107ad4-b0f3-4d12-4650-4e7656ed66ea@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dhdang@apm.com \
--cc=hotran@apm.com \
--cc=itaru.kitayama@riken.jp \
--cc=jdelvare@suse.com \
--cc=lho@apm.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox