From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C411C25B48 for ; Thu, 26 Oct 2023 05:01:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjJZFBe (ORCPT ); Thu, 26 Oct 2023 01:01:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjJZFBd (ORCPT ); Thu, 26 Oct 2023 01:01:33 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9A2293; Wed, 25 Oct 2023 22:01:31 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so324439276.1; Wed, 25 Oct 2023 22:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698296491; x=1698901291; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=3AT7KXQGUsciZNpjF//+rR7xY7+/xeq6fT/G1a+QH3A=; b=aiS5Ik5YTkEi1waW3nF1plYmh7BLMv9EMEHGW34h0w1XCXDqRAH5Z1yGyNF27/3ndg Nbm5WrS/R3XAUX9fNsuCzJ337lfk4yG7GI4qbji+c8F4U6PCwazoUuu11690Q1ZeytNC /Xzuvcem8brz/kJVphupyfJE0e0ohs0rPiA44PWoPAGd7/Ew3Sh1+WcwPuhwHU1N9W31 UN8EV9z4UbeA4gZsq5iw4QDBtPygs33kGCCCszU6st/3BORUaWudb56ZK9pukbXljfqF hNkV5onZ9FV51IV96QxILwNVPNncNY1ZSJDkxub9bENhPoXJbgOi67+8GZB4IRHaH74k wLjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698296491; x=1698901291; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3AT7KXQGUsciZNpjF//+rR7xY7+/xeq6fT/G1a+QH3A=; b=Nzxt7LVDOg4AdgutQS/96Bjao+9r9DJi4jeByrqNMIht2kS/eQ2YYo4rKFHs26cwB1 hCXrrmALVIaxslJ9OHzywyZLS/qCLE/QmHeW5BLZ2CCZjBLsIo0wxtCDVsfQb0zf2LGo 7i2Y43R1tvJ1SLlPrPv1ACSLxc9xnBwcanVVTeSbMhHjE3lCP19mIBv5vVn+cZbb6qgT 6Bvgd08Xr7nGtgwKFQXxTOjfZWzcZT9a63tDyRzjmQyLQBc/KIPSn0Zq8nKv6/uuJot2 4F0yBUtCY1fjWpwF5WifP6giF4hDwaEMKRJLio4Jl9Ud/b0ioSnHH3o6p4FuHpn0CNox BTmA== X-Gm-Message-State: AOJu0YwgET9Tbf6q5DDTAkBx0HkiXQ7Dr8rf7i0niuAzGSmbse1U34nB XVsSslRRjPGugnKQFv2e4g4= X-Google-Smtp-Source: AGHT+IHYLLogG8ok5wIpCRoGQhAZePmymJghIRX0SagV0FJqYysItuPn8cBQLmJQJHwivRTvpQ+6Cg== X-Received: by 2002:a25:d00c:0:b0:d9a:55e5:9a0c with SMTP id h12-20020a25d00c000000b00d9a55e59a0cmr15616304ybg.26.1698296490725; Wed, 25 Oct 2023 22:01:30 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id ch20-20020a0569020b1400b00da086d6921fsm834090ybb.50.2023.10.25.22.01.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 22:01:29 -0700 (PDT) Sender: Guenter Roeck Message-ID: <3a8fd5d6-9b79-76de-80fe-b39e24510dec@roeck-us.net> Date: Wed, 25 Oct 2023 22:01:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add ROG Crosshair X670E Gene. Content-Language: en-US To: Ellie Hermaszewska Cc: eugene.shalygin@gmail.com, Jean Delvare , Jonathan Corbet , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231019135640.434752-1-kernel@monoid.al> From: Guenter Roeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 10/25/23 21:46, Ellie Hermaszewska wrote: > On 10/26/23 03:35, Guenter Roeck wrote: > > This is not an acceptable commit description. > > This is not acceptable feedback. > > I am unable to accept it because it is not clear to me what you think > should be changed. > > Is it because I misplaced the message to Eugene? Is it because of the > Greek characters? Is is not descriptive enough of the change, or in the > wrong tense, or has incorrect punctuation? Do I need to include my > testing methodology? > > If it's only something minor, then please also feel free to correct it > yourself before applying. If you can't or it's not something minor, > then please let me know what ought to change and I can try to correct it. > > If you don't let me know, then I will have to guess and possibly waste everyone's time further. > Please consider reading and following the directions in Documentation/process/submitting-patches.rst. Thanks, Guenter