From: Guenter Roeck <linux@roeck-us.net>
To: Grant Peltier <grantpeltier93@gmail.com>
Cc: robh@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com,
grant.peltier.jg@renesas.com, brandon.howell.jg@renesas.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hwmon: (pmbus/isl68137) add support for voltage divider on Vout
Date: Thu, 24 Oct 2024 13:03:11 -0700 [thread overview]
Message-ID: <3f460b62-4cd1-49dd-a98b-1fbcfdbd3af0@roeck-us.net> (raw)
In-Reply-To: <ZxqjY-5MvsZfzf3U@raspberrypi>
On 10/24/24 12:43, Grant Peltier wrote:
[ ... ]
>>> + of_property_read_u32_array(child, "renesas,vout-voltage-divider",
>>
>> Ultimately this potentially applies to _all_ hardware monitoring chips,
>> so I would very much prefer a generic voltage divider property definition.
>>
>
> There is a parallel conversation on PATCH v3 2/2 about this. Would you
> prefer that I match the implementation for maxim20730?
>
I would prefer, in the order of preference,
1) an applicable generic property definition
2) a definition that is already used elsewhere
3) a new chips specific definition
From my perspective, matching the maxim20730 implementation should only
be considered if the generic definition does not meet the chip requirements.
Thanks,
Guenter
next prev parent reply other threads:[~2024-10-24 20:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 1:56 [PATCH v2 0/2] dt-bindings: hwmon: pmbus: add bindings for isl68137 Grant Peltier
2024-10-23 1:58 ` [PATCH v2 1/2] hwmon: (pmbus/isl68137) add support for voltage divider on Vout Grant Peltier
2024-10-23 7:34 ` Geert Uytterhoeven
2024-10-23 16:40 ` Grant Peltier
2024-10-24 17:48 ` Guenter Roeck
2024-10-24 19:43 ` Grant Peltier
2024-10-24 20:03 ` Guenter Roeck [this message]
2024-10-23 1:58 ` [PATCH v2 2/2] dt-bindings: hwmon: isl68137: add bindings to support voltage dividers Grant Peltier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f460b62-4cd1-49dd-a98b-1fbcfdbd3af0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=brandon.howell.jg@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=grant.peltier.jg@renesas.com \
--cc=grantpeltier93@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox