Re: [PATCH 1/2] hwmon: (max6697) Fix swapped temp{1,8} critical alarms

[Guenter Roeck <linux@roeck-us.net>]

On 7/14/24 00:06, Tzung-Bi Shih wrote:
> On Sat, Jul 13, 2024 at 02:34:01PM -0700, Guenter Roeck wrote:
>> The critical alarm bit for the local temperature sensor (temp1) is in
>> bit 7 of register 0x45 (not bit 6), and the critical alarm bit for remote
>> temperature sensor 7 (temp8) is in bit 6 (not bit 7).
>>
>> This only affects MAX6581 since all other chips supported by this driver
>> do not support those critical alarms.
>>
>> Fixes: 5372d2d71c46 ("hwmon: Driver for Maxim MAX6697 and compatibles")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Double checked with the datasheet[1],

I checked this several times because I couldn't believe that I got it wrong
when I wrote the driver. Thanks a lot for the reviews and for cross-checking !

Guenter

> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> 
> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/max6581.pdf
>