From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Günter Röck" <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: hwmon/amc6821: Use common error handling code in amc6821_init_client()
Date: Wed, 25 Oct 2017 08:03:13 +0200 [thread overview]
Message-ID: <482baa1b-ea2d-76db-3aee-719b6645156c@users.sourceforge.net> (raw)
In-Reply-To: <20171024201812.GA5769@roeck-us.net>
> Nack; I am not a friend of that much verboseness to start with,
> and I don't think the patch improves readability.
* Do you care to avoid code duplication for two error messages in this use case?
* How do you think about to return a single error code directly
without using an intermediate variable?
Regards,
Markus
prev parent reply other threads:[~2017-10-25 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 20:10 [PATCH] hwmon/amc6821: Use common error handling code in amc6821_init_client() SF Markus Elfring
2017-10-24 20:18 ` Guenter Roeck
2017-10-25 6:03 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482baa1b-ea2d-76db-3aee-719b6645156c@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox