From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: hwmon: Add Amphenol ChipCap 2
Date: Thu, 9 Nov 2023 09:41:33 +0100 [thread overview]
Message-ID: <4b1d6fe8-529b-4cf4-ba0a-697c7aeac174@linaro.org> (raw)
In-Reply-To: <269222d8-b72f-4c7a-a19e-a82964e29ec8@gmail.com>
On 08/11/2023 13:44, Javier Carrasco wrote:
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - amphenol,cc2dxx
>>> + - amphenol,cc2dxxs
>>
>> What does xx stand for? Wildcard? I do not see cc2dxx in part numbers.
>> We expect specific compatibles, not generic. What are the differences
>> between all parts?
>>
> There are two device families: cc2dxx and cc2dxxs, where xx indicates
> the voltage and the accuracy. That does not change how the devices works
> and it is not relevant for the driver. The 's' indicates that it is a
> sleep device, and that modifies how it works.
> I listed the supported part numbers in the hwmon documentation, where
> they are also divided into these two families.
If the number of devices is relatively small, list them all. Otherwise
choose one device model and use it. No family models. No wildcards.
>>> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-09 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 12:29 [PATCH 0/4] hwmon: Add support for Amphenol ChipCap 2 Javier Carrasco
2023-11-08 12:29 ` [PATCH 1/4] dt-bindings: vendor-prefixes: add Amphenol Javier Carrasco
2023-11-08 12:31 ` Krzysztof Kozlowski
2023-11-08 12:29 ` [PATCH 2/4] hwmon: (core) Add support for humidity min/max alarm Javier Carrasco
2023-11-08 12:29 ` [PATCH 3/4] hwmon: Add support for Amphenol ChipCap 2 Javier Carrasco
2023-11-08 12:41 ` Krzysztof Kozlowski
2023-11-08 16:35 ` Javier Carrasco
2023-11-09 8:40 ` Krzysztof Kozlowski
2023-11-09 8:59 ` Javier Carrasco
2023-11-09 9:35 ` Krzysztof Kozlowski
2023-11-09 9:52 ` Javier Carrasco
2023-11-09 10:23 ` Krzysztof Kozlowski
2023-11-08 12:29 ` [PATCH 4/4] dt-bindings: hwmon: Add " Javier Carrasco
2023-11-08 12:34 ` Krzysztof Kozlowski
2023-11-08 12:44 ` Javier Carrasco
2023-11-09 8:41 ` Krzysztof Kozlowski [this message]
2023-11-09 14:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1d6fe8-529b-4cf4-ba0a-697c7aeac174@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox