Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Vishnu Razdan <vrazdan@openai.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	vikash.chandola@linux.intel.com
Subject: Re: [PATCH] hwmon: (pmbus) Clear generic status alarms with CLEAR_FAULTS
Date: Fri, 28 Aug 2026 08:59:53 -0700	[thread overview]
Message-ID: <53d1d7d5-629e-48fa-8947-3a3c294ff16b@roeck-us.net> (raw)
In-Reply-To: <20260824-vrazdan-pmbus-status-word-b4-v1-1-2606ecd0c029@openai.com>

On Mon, Aug 24, 2026 at 11:58:00PM -0700, Vishnu Razdan wrote:
> From: Vishnu Razdan <vrazdan@openai.com>
> 
> Some hwmon alarms fall back to STATUS_WORD summary bits when no
> individual limit alarm is available. On PMBus 1.2 and newer devices,
> pmbus_get_boolean() acknowledges these alarms with the same byte-data
> write used for detailed status registers. For example, PB_STATUS_INPUT
> is 0x2000, so it is truncated to zero when passed to
> _pmbus_write_byte_data(). The resulting write cannot acknowledge the
> input alarm.
> 
> PMBus 1.3 Part II, sections 10.2.4 and 10.2.5, excludes ordinary
> STATUS_BYTE and STATUS_WORD summary bits from individual clearing.
> Their summary bits clear when the underlying status bits clear, so
> changing this to a word-data write would not fix the generic input
> alarm either.
> 
> Use the existing page CLEAR_FAULTS path for generic STATUS_WORD
> alarms, including devices whose status accessor uses STATUS_BYTE.
> Keep individual byte writes for detailed status registers on PMBus
> 1.2 and newer devices. As with the existing older-device fallback,
> CLEAR_FAULTS can clear other latched status; an active condition can
> reassert its status.
> 
> Fixes: 35f165f08950 ("hwmon: (pmbus) Clear pmbus fault/warning bits after read")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Vishnu Razdan <vrazdan@openai.com>

Applied.

Thanks,
Guenter

      parent reply	other threads:[~2026-08-28 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  6:58 [PATCH] hwmon: (pmbus) Clear generic status alarms with CLEAR_FAULTS Vishnu Razdan via B4 Relay
2026-08-25  7:11 ` sashiko-bot
2026-08-28 15:59 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53d1d7d5-629e-48fa-8947-3a3c294ff16b@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vikash.chandola@linux.intel.com \
    --cc=vrazdan@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox