Re: hwmon driver with misc interface

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2018-07-10 at 13:44 -0700, Guenter Roeck wrote:
> > > Yes, I think that would be more appropriate.
> > 
> > This still won't work, since then we wouldn't have those attributes
> > available in the P8 version of the driver (which has no fsi-occ driver). In
> > addition, how would the poll response data get from the hwmon driver to the
> > fsi-occ driver? Yet another interface? Seems awkward.
> > 
> > How about debugfs? We don't really mind where the attributes are, just that
> > the data is exposed somewhere...
> > 
> 
> You are essentially confirming that using sysfs attributes would not be
> appropriate. I have no problems with using debugfs; you have a free ride
> there.

I disagree.

If the attributes are used for the normal operation of the system then
they should be in sysfs.

A system should be able to function normally without debugfs mounted.

Those attributes are about monitoring proper operations of the OCC
right ? Or are there other things here ? I don't see any reason why
those couldn't hang off the device sysfs node...

Cheers,
Ben.