From: Thor Thayer <tthayer@opensource.altera.com>
To: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: <lee.jones@linaro.org>, <linus.walleij@linaro.org>,
<gnurou@gmail.com>, <jdelvare@suse.com>, <linux@roeck-us.net>,
<robh+dt@kernel.org>, <pawell.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<linux-gpio@vger.kernel.org>, <linux-hwmon@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [RFC 5/8] ARM: socfpga: dts: Add Devkit A10-SR fields for Arria10
Date: Thu, 31 Mar 2016 13:28:03 -0500 [thread overview]
Message-ID: <56FD6C33.8040907@opensource.altera.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1603301240250.21508@linux-builds1>
On 03/30/2016 12:42 PM, Dinh Nguyen wrote:
> On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote:
>
>> From: Thor Thayer <tthayer@opensource.altera.com>
>>
>> Add the Altera Arria10 System Resource node. This is a Multi-Function
>> device with GPIO and HWMON support.
>>
>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
>>
>> + spi1: spi@ffda5000 {
>> + compatible = "snps,dw-apb-ssi";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <0xffda5000 0x100>;
>> + interrupts = <0 102 4>;
>> + num-chipselect = <4>;
>> + bus-num = <0>;
>> + /*32bit_access;*/
>> + tx-dma-channel = <&pdma 16>;
>> + rx-dma-channel = <&pdma 17>;
>> + clocks = <&spi_m_clk>;
>> + status = "disabled";
>> + };
>> +
>
> I think you need to split this into 2 patches, 1 for adding the SPI nodes, and
> the 2nd for adding the slave device.
>
> BR,
> Dinh
>
OK. Thanks for reviewing.
next prev parent reply other threads:[~2016-03-31 18:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 19:13 [RFC] Addition of Altera Arria10 System Resource Chip tthayer
2016-03-29 19:13 ` [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings tthayer
2016-03-29 19:13 ` [RFC 2/8] MAINTAINERS: Addition of Altera Arria10 System Resource Chip tthayer
2016-03-29 19:13 ` [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit " tthayer
2016-03-29 19:13 ` [RFC 4/8] gpio: altera-a10sr: Add A10 System Resource Chip GPIO support tthayer
2016-04-01 12:17 ` Linus Walleij
2016-04-01 20:34 ` Thor Thayer
2016-04-08 11:39 ` Linus Walleij
2016-03-29 19:13 ` [RFC 5/8] ARM: socfpga: dts: Add Devkit A10-SR fields for Arria10 tthayer
2016-03-30 17:42 ` Dinh Nguyen
2016-03-31 18:28 ` Thor Thayer [this message]
2016-03-29 19:13 ` [RFC 6/8] ARM: socfpga: dts: Add LED framework to A10-SR GPIO tthayer
2016-03-29 19:13 ` [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor tthayer
2016-03-29 20:16 ` Guenter Roeck
2016-03-29 21:43 ` Thor Thayer
2016-03-29 22:29 ` Mark Brown
2016-03-29 22:30 ` Guenter Roeck
2016-03-29 19:13 ` [RFC 8/8] ARM: socfpga: dts: Add Devkit Arria10-SR HWMON tthayer
2016-03-30 8:14 ` [RFC] Addition of Altera Arria10 System Resource Chip Lee Jones
2016-03-30 8:18 ` [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor Lee Jones
2016-03-30 8:18 ` [RFC 4/8] gpio: altera-a10sr: Add A10 System Resource Chip GPIO support Lee Jones
2016-03-30 8:19 ` [RFC 2/8] MAINTAINERS: Addition of Altera Arria10 System Resource Chip Lee Jones
2016-03-30 11:36 ` [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings Lee Jones
2016-03-31 14:06 ` Rob Herring
2016-03-31 18:21 ` Thor Thayer
2016-04-01 8:14 ` Lee Jones
2016-04-01 20:21 ` Thor Thayer
2016-03-30 11:51 ` [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip Lee Jones
2016-03-30 14:52 ` Thor Thayer
2016-03-30 14:52 ` Lee Jones
2016-03-30 16:10 ` Mark Brown
2016-03-30 14:27 ` [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor Thor Thayer
2016-03-31 9:11 ` [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip Lee Jones
2016-04-15 16:57 ` [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings Thor Thayer
2016-04-18 7:44 ` Lee Jones
2016-04-18 7:46 ` Lee Jones
2016-04-18 14:51 ` Thor Thayer
2016-04-18 15:07 ` Thor Thayer
2016-04-19 7:25 ` Lee Jones
2016-04-19 14:38 ` Thor Thayer
2016-04-20 1:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD6C33.8040907@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawell.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox