From: Nishanth Menon <nm@ti.com>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>
Cc: <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Eduardo Valentin <edubezval@gmail.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v2 3/5] hwmon: (tmp102) Improve handling of initial read delay
Date: Sun, 26 Jun 2016 08:31:44 -0500 [thread overview]
Message-ID: <576FD940.4070102@ti.com> (raw)
In-Reply-To: <1466908825-14222-3-git-send-email-linux@roeck-us.net>
On 06/25/2016 09:40 PM, Guenter Roeck wrote:
[...]
> /* convert left adjusted 13-bit TMP102 register value to milliCelsius */
> @@ -78,8 +82,16 @@ static struct tmp102 *tmp102_update_device(struct device *dev)
> struct tmp102 *tmp102 = dev_get_drvdata(dev);
> struct i2c_client *client = tmp102->client;
>
> + /* Is it too early to return a conversion ? */
> + if (time_before(jiffies, tmp102->ready_time)) {
> + unsigned long sleeptime = tmp102->ready_time - jiffies;
> +
> + msleep(jiffies_to_msecs(sleeptime));
> + }
> +
While msleep can indeed work and simplify, in case of usage for
example with thermal framework, if the data is not ready and we return
-EAGAIN, it lets the thermal framework go and read other sensors
instead of being blocked on the tmp102 conversion of data.
Eduardo, Rui: what is your view on this approach?
Patch: https://patchwork.kernel.org/patch/9198961/
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2016-06-26 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 2:40 [PATCH v2 1/5] hwmon: (tmp102) Use devm_add_action to register cleanup function Guenter Roeck
2016-06-26 2:40 ` [PATCH v2 2/5] hwmon: (tmp102) Drop FSF address Guenter Roeck
2016-06-26 13:32 ` Nishanth Menon
2016-06-26 2:40 ` [PATCH v2 3/5] hwmon: (tmp102) Improve handling of initial read delay Guenter Roeck
2016-06-26 13:31 ` Nishanth Menon [this message]
2016-06-26 14:02 ` Guenter Roeck
2016-06-26 2:40 ` [PATCH v2 4/5] hwmon: (tmp102) Rework chip configuration Guenter Roeck
2016-06-26 2:40 ` [PATCH v2 5/5] hwmon: (tmp102) Convert to use regmap, and drop local cache Guenter Roeck
2016-06-26 13:27 ` Nishanth Menon
2016-06-26 14:17 ` Guenter Roeck
2016-06-26 13:32 ` [PATCH v2 1/5] hwmon: (tmp102) Use devm_add_action to register cleanup function Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576FD940.4070102@ti.com \
--to=nm@ti.com \
--cc=edubezval@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox