From: Guenter Roeck <linux@roeck-us.net>
To: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
Cc: linux-hwmon <linux-hwmon@vger.kernel.org>,
Thilo Cestonaro <thilo@cestona.ro>
Subject: Re: [PATCH v7] hwmon: added kernel module for FTS BMC chip "Teutates"
Date: Mon, 18 Jul 2016 07:41:01 -0700 [thread overview]
Message-ID: <578CEA7D.6000704@roeck-us.net> (raw)
In-Reply-To: <1468842689-31582-1-git-send-email-thilo.cestonaro@ts.fujitsu.com>
On 07/18/2016 04:51 AM, Thilo Cestonaro wrote:
> From: Thilo Cestonaro <thilo@cestona.ro>
>
> This driver implements support for the FTS BMC Chip "Teutates".
>
> Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>
> ---
[ ... ]
> +
> +/*****************************************************************************/
> +/* Module initialization / remove functions */
> +/*****************************************************************************/
> +static int fts_remove(struct i2c_client *client)
> +{
> + struct fts_data *data = dev_get_drvdata(&client->dev);
> +
> + watchdog_unregister_device(&data->wdd);
> + return 0;
> +}
> +
> +static int fts_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +{
> + u8 revision;
> + struct fts_data *data;
> + int err;
> + s8 deviceid;
One (hopefully) last question: Effectively this means that any device ID >=0x80
will be identified as error. Is this on purpose ? It is quite unusual.
Thanks,
Guenter
next prev parent reply other threads:[~2016-07-18 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 11:51 [PATCH v7] hwmon: added kernel module for FTS BMC chip "Teutates" Thilo Cestonaro
2016-07-18 14:41 ` Guenter Roeck [this message]
2016-07-18 15:37 ` Thilo Cestonaro
2016-07-19 3:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578CEA7D.6000704@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=thilo.cestonaro@ts.fujitsu.com \
--cc=thilo@cestona.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox