* [PATCH] hwmon-ntc_thermistor: Delete an unnecessary check before the function call "iio_channel_release"
[not found] ` <5317A59D.4@users.sourceforge.net>
@ 2016-07-18 18:54 ` SF Markus Elfring
2016-07-19 3:35 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2016-07-18 18:54 UTC (permalink / raw)
To: linux-hwmon, Günter Röck, Jean Delvare
Cc: LKML, kernel-janitors, Julia Lawall
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 18 Jul 2016 20:34:41 +0200
The iio_channel_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hwmon/ntc_thermistor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 8ef7b71..100878a 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -361,8 +361,7 @@ ntc_thermistor_parse_dt(struct platform_device *pdev)
}
static void ntc_iio_channel_release(struct ntc_thermistor_platform_data *pdata)
{
- if (pdata->chan)
- iio_channel_release(pdata->chan);
+ iio_channel_release(pdata->chan);
}
#else
static struct ntc_thermistor_platform_data *
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon-ntc_thermistor: Delete an unnecessary check before the function call "iio_channel_release"
2016-07-18 18:54 ` [PATCH] hwmon-ntc_thermistor: Delete an unnecessary check before the function call "iio_channel_release" SF Markus Elfring
@ 2016-07-19 3:35 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2016-07-19 3:35 UTC (permalink / raw)
To: SF Markus Elfring, linux-hwmon, Jean Delvare
Cc: LKML, kernel-janitors, Julia Lawall
On 07/18/2016 11:54 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 18 Jul 2016 20:34:41 +0200
>
> The iio_channel_release() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
A much better change would be to use devm_iio_channel_get() instead of
iio_channel_get(), and to remove ntc_iio_channel_release() completely.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-19 3:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.sourceforge.net>
2016-07-18 18:54 ` [PATCH] hwmon-ntc_thermistor: Delete an unnecessary check before the function call "iio_channel_release" SF Markus Elfring
2016-07-19 3:35 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox