From: Guenter Roeck <linux@roeck-us.net>
To: Thilo Cestonaro <thilo@cestona.ro>,
Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
Cc: linux-hwmon <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v7] hwmon: added kernel module for FTS BMC chip "Teutates"
Date: Mon, 18 Jul 2016 20:40:45 -0700 [thread overview]
Message-ID: <578DA13D.4090701@roeck-us.net> (raw)
In-Reply-To: <578CF7CC.7070904@cestona.ro>
On 07/18/2016 08:37 AM, Thilo Cestonaro wrote:
> Am 18.07.2016 um 16:41 schrieb Guenter Roeck:
>> On 07/18/2016 04:51 AM, Thilo Cestonaro wrote:
>>> From: Thilo Cestonaro <thilo@cestona.ro>
>>>
>>> This driver implements support for the FTS BMC Chip "Teutates".
>>>
>>> Signed-off-by: Thilo Cestonaro <thilo@cestona.ro>
>>> ---
>>
>> [ ... ]
>>
>>> +
>>> +/*****************************************************************************/
>>>
>>> +/* Module initialization / remove functions */
>>> +/*****************************************************************************/
>>>
>>> +static int fts_remove(struct i2c_client *client)
>>> +{
>>> + struct fts_data *data = dev_get_drvdata(&client->dev);
>>> +
>>> + watchdog_unregister_device(&data->wdd);
>>> + return 0;
>>> +}
>>> +
>>> +static int fts_probe(struct i2c_client *client, const struct
>>> i2c_device_id *id)
>>> +{
>>> + u8 revision;
>>> + struct fts_data *data;
>>> + int err;
>>> + s8 deviceid;
>>
>> One (hopefully) last question: Effectively this means that any device
>> ID >=0x80
>> will be identified as error. Is this on purpose ? It is quite unusual.
> The driver looks especially for 0x11, which means 0x10 - Baseboard
> Management Controller and 0x01 Teutates. (spec. page 8, Page 0 Offset 0)
> So anything not 1Xh will be an error ENODEV and then the switch filters
> for X1h and all not 01h will be an error ENODEV, as this driver isn't
> written for anything different to 0x11.
> So "s8" is ok here.
>
Hmmm ... I don't really see the point of using s8 instead of int,
but I'll accept it.
Applied to -next.
Guenter
prev parent reply other threads:[~2016-07-19 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 11:51 [PATCH v7] hwmon: added kernel module for FTS BMC chip "Teutates" Thilo Cestonaro
2016-07-18 14:41 ` Guenter Roeck
2016-07-18 15:37 ` Thilo Cestonaro
2016-07-19 3:40 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578DA13D.4090701@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=thilo.cestonaro@ts.fujitsu.com \
--cc=thilo@cestona.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox