* [PATCH] hwmon: ftsteutates: add watchdog dependency
@ 2016-07-20 10:37 Arnd Bergmann
2016-07-20 13:29 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-07-20 10:37 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck
Cc: Arnd Bergmann, Thilo Cestonaro, linux-hwmon, linux-kernel
The newly added fts "Teutates" hwmon chip contains a watchdog but fails
to link when the watchdog subsystem is disabled:
drivers/hwmon/built-in.o: In function `fts_remove':
:(.text+0x161d8): undefined reference to `watchdog_unregister_device'
drivers/hwmon/built-in.o: In function `fts_probe':
:(.text+0x16cb4): undefined reference to `watchdog_register_device'
This adds a Kconfig dependency in the same way that the other
similar drivers have.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"")
---
drivers/hwmon/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 15479eb15fa2..eaf2f916d48c 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -488,7 +488,8 @@ config SENSORS_FSCHMD
config SENSORS_FTSTEUTATES
tristate "Fujitsu Technology Solutions sensor chip Teutates"
- depends on I2C
+ depends on I2C && WATCHDOG
+ select WATCHDOG_CORE
help
If you say yes here you get support for the Fujitsu Technology
Solutions (FTS) sensor chip "Teutates" including support for
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: ftsteutates: add watchdog dependency
2016-07-20 10:37 [PATCH] hwmon: ftsteutates: add watchdog dependency Arnd Bergmann
@ 2016-07-20 13:29 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2016-07-20 13:29 UTC (permalink / raw)
To: Arnd Bergmann, Jean Delvare; +Cc: Thilo Cestonaro, linux-hwmon, linux-kernel
On 07/20/2016 03:37 AM, Arnd Bergmann wrote:
> The newly added fts "Teutates" hwmon chip contains a watchdog but fails
> to link when the watchdog subsystem is disabled:
>
> drivers/hwmon/built-in.o: In function `fts_remove':
> :(.text+0x161d8): undefined reference to `watchdog_unregister_device'
> drivers/hwmon/built-in.o: In function `fts_probe':
> :(.text+0x16cb4): undefined reference to `watchdog_register_device'
>
> This adds a Kconfig dependency in the same way that the other
> similar drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"")
Thanks - folded into original patch.
Guenter
> ---
> drivers/hwmon/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 15479eb15fa2..eaf2f916d48c 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -488,7 +488,8 @@ config SENSORS_FSCHMD
>
> config SENSORS_FTSTEUTATES
> tristate "Fujitsu Technology Solutions sensor chip Teutates"
> - depends on I2C
> + depends on I2C && WATCHDOG
> + select WATCHDOG_CORE
> help
> If you say yes here you get support for the Fujitsu Technology
> Solutions (FTS) sensor chip "Teutates" including support for
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-20 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-20 10:37 [PATCH] hwmon: ftsteutates: add watchdog dependency Arnd Bergmann
2016-07-20 13:29 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox