From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AF532BE643 for ; Fri, 12 Dec 2025 16:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765557233; cv=none; b=TrLQKG/HhCOWjsDg8trrSTNkdwe+zrXsfiZEyxFquWoNqyRTj/GrR6Umpwu7RgLDOaip20H73BGftpJXCI0S64DGvuAN0wG7C+28lOEByRJbED+m5Yiomatr//E0EBrllY9x2Jhv8Dsey7K31uweUyL2BXfvJB2Qsuqbd9S6DIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765557233; c=relaxed/simple; bh=vTwFW/M5orw9Y0dilyu2imvoiT3dfkAfNeGwFzDzihI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=bAFtJSZRqpKcuGdAoFr/uRMse7dh2QntZwLk6XFQtWYYJtvaOVTP08eAcclbaAHT6p02OCpnPJGU325ezro9obtJojJu4UWOjiP64rF6PePiN/MfsAwYlNW/pw+L9u/pl71B3KLkMrz+efsrUG2XtL7pCMUNfCdr/7OgRKswdOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H7+2NI56; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H7+2NI56" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4775895d69cso6055685e9.0 for ; Fri, 12 Dec 2025 08:33:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765557229; x=1766162029; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=vTwFW/M5orw9Y0dilyu2imvoiT3dfkAfNeGwFzDzihI=; b=H7+2NI569vSc69UiOEvuH8qkQmjtOOcRULQTsOVgVh3JRQg+alKiDPEsrTkBLlHUK8 aFF9vrrQg5McISaMC0mnCQj7uC+PfgTa0nSKE5T0E6yS0JLh2prQPHLkM7UOWa+JZ/65 vNWUoT2n3kCacb46OlKe/PzpRkmHVM3PZXOx1eDN608pH141z/HYrVpOXHJQe2tmPWOw JVK3LYQ1kuQymGTpLpCTKpdulPGL92y3pRr0QEMK4PDlEuUvXA3LhsFvTwOCPDv6Iyy+ 3OkOEykEsKjw5IpBvFgjhBE9vCLF/UaG9FgRcwVTlHDDv8kWyL+h7LAaJ0C41gLm1ff0 0U2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765557229; x=1766162029; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vTwFW/M5orw9Y0dilyu2imvoiT3dfkAfNeGwFzDzihI=; b=QIN+ly6hXkRiTLPExHjrN407UGehboMdinmJ/Qz2+Mohby8r2KQlI22LrjHBOHmkIE u1lD3dgWVn9pI/cFz38PP1Q7n+Ti6109lBbcIoEI4le4goN5w60eNrsJIdUfw9Z2QFJu Lv8qKE2hw+WtMFHVMwt93uZ2jElOpkIk/95Pfw63HdlObRpoQdNnEAnjavJP4tYyQJEq jRdUHlHnfMQ/bFM/s08tNI5EeyNMDmAJN9MpcLXtQJ7K39Dbg6oJhDFcX4pZ0BNbVWPx jLTXMU+BMak/zJnk0Sfwk5az6kYi4oo8xhJplOhNkGzOo+ut5gIbOwSxRW0h3+cXr2+o jRrQ== X-Forwarded-Encrypted: i=1; AJvYcCUglioQe66h/jjco6DdxSw0oGFEen/sugdtlPlAIZIO7ovDO5gIgn/DUjj9jfbM3GiW/XF+hiQ7zcyCkA==@vger.kernel.org X-Gm-Message-State: AOJu0YwovGDSx57lk21ogtY50rYebpWK/1r72noaQa9zdpFzDMlElLF1 lzJ8dNrKdTIkZXj2nj2FHUBISCKnNE7Ye2L5rIQO/6ogPFVfAgdAJ5CS X-Gm-Gg: AY/fxX6cfUkZcJmcDOcUr8VRGxcHoTDt+OMfs/z+tBB8CZU7M8T6/f1/eO6j6GBg382 KQ5JKZQHxG7oS/qe9WNtyAEoSv0PXBjM7R5n4c76tDwlb7YeKK9EyzzNWYv0+pbU4kZxpaydFLu 3IKM4Yc2UGaX35OJxKr7ZkYSmFFSG60dwwy9aMKxGndMlFd3EdwJ4qrFenPlJnbTYu7qZABQMDE FeEXbztUrAYOsyHfw69LnPTTRpSlC0TTXiUhOqDUX5OENEqwxV93LQFGxSLP3i+l5q6xmrT9NAv 2maTlCJ/xp0unjKeywBKuA55HBILqEEJtR3BubY49CRLIDabxM45y6z7Exfa+bh5q9QcwSmIWKr y2rApf67KyPWJ8LVie4TyS7TSc1tvqRDmvED2bp3HexEa9qdT5f/DfDXkgcn0kHldXh5i2igoXW LyjEQfyYEfNtaxBFXcxhQ= X-Google-Smtp-Source: AGHT+IGZ0L9l7A5Odalp5J0/0NIl+zjmCJtcDKPahPJ7kG1ItBw9GgpXroQrL1TURDT38jXXgCfg8w== X-Received: by 2002:a05:600c:4f86:b0:45d:d97c:236c with SMTP id 5b1f17b1804b1-47a8f9071c6mr29585235e9.21.1765557229319; Fri, 12 Dec 2025 08:33:49 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8a7044csm14112522f8f.15.2025.12.12.08.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 08:33:49 -0800 (PST) Message-ID: <67209860ae2ff5626b7eaa50f2dd4b496eaa06d3.camel@gmail.com> Subject: Re: [PATCH v4 2/3] hwmon: ltc4283: Add support for the LTC4283 Swap Controller From: Nuno =?ISO-8859-1?Q?S=E1?= To: Guenter Roeck , nuno.sa@analog.com, linux-hwmon@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Cc: Krzysztof Kozlowski , Conor Dooley , Jean Delvare , Jonathan Corbet , Linus Walleij , Bartosz Golaszewski Date: Fri, 12 Dec 2025 16:34:29 +0000 In-Reply-To: <144d50f7-398c-4b10-bd21-a6d0c6c7b4c8@roeck-us.net> References: <20251204-ltc4283-support-v4-0-db0197fd7984@analog.com> <20251204-ltc4283-support-v4-2-db0197fd7984@analog.com> <144d50f7-398c-4b10-bd21-a6d0c6c7b4c8@roeck-us.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-12-06 at 10:40 -0800, Guenter Roeck wrote: > On 12/4/25 08:15, Nuno S=C3=A1 via B4 Relay wrote: > > From: Nuno S=C3=A1 > >=20 > > Support the LTC4283 How Swap Controller. The device features programmab= le > > current limit with foldback and independently adjustable inrush current= to > > optimize the MOSFET safe operating area (SOA). The SOA timer limits MOS= FET > > temperature rise for reliable protection against overstresses. > >=20 > > An I2C interface and onboard ADC allow monitoring of board current, > > voltage, power, energy, and fault status. > >=20 > > Signed-off-by: Nuno S=C3=A1 >=20 > I finally found the time to write module test code for the driver. >=20 Thanks! > Some early feedback: >=20 > - The driver must work with non-devicetree systems and without device > =C2=A0=C2=A0 property support. Select defaults where necessary. I'll double check that... But one thing that already comes to mind is rsens= e? Rsense is the main design choice for a thing like this. Not sure we can decide on = a meaningful default for it? I believe we have the same situation for ltc4282.c > - Attributes marked as readable in the is_visible function must be readab= le. > =C2=A0=C2=A0 It is not acceptable to return -EOPNOTSUPP. That applies to = all > =C2=A0=C2=A0 reset_history attributes and maybe to others. Hmm that's a mistake. They should be WO and I have the same bug in ltc4282 = so I need to send a patch. - Nuno S=C3=A1 >=20