Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694

Ming Yu
2024-12-12T05:27:58Z

Dear Krzysztof,

Thank you for your comments,

Krzysztof Kozlowski <krzk@kernel.org> 於 2024年12月10日 週二 下午10:38寫道：
>
> > +
> > + dev_set_drvdata(dev, nct6694);
> > + usb_set_intfdata(iface, nct6694);
> > +
> > + ret = mfd_add_hotplug_devices(dev, nct6694_dev, ARRAY_SIZE(nct6694_dev));
> > + if (ret)
> > + goto err_mfd;
> > +
> > + dev_info(dev, "Probed device: (%04X:%04X)\n", id->idVendor, id->idProduct);
>
> Drop. Duplicating existing messages and interfaces. Your driver is
> supposed to be silent on success.
>

Okay, I will drop it in v4.

> > + return 0;
> > +
> > +err_mfd:
> > + usb_kill_urb(nct6694->int_in_urb);
> > +err_urb:
> > + usb_free_urb(nct6694->int_in_urb);
> > + return dev_err_probe(dev, ret, "Probe failed\n");
>
> No, this should go to individual call causing errors so this will be
> informative. Above is not informative at all and kernel already reports
> this, so drop.
>

Okay, I will drop it in v4.

> > +}
> > +
> > +static void nct6694_usb_disconnect(struct usb_interface *iface)
> > +{
> > + struct usb_device *udev = interface_to_usbdev(iface);
> > + struct nct6694 *nct6694 = usb_get_intfdata(iface);
>

Best regards,
Ming