Re: [PATCH] hwmon: (emc1403) Add support for EMC1438.

[Guenter Roeck <linux@roeck-us.net>]

On Fri, Apr 26, 2024 at 04:09:37PM +0200, Lars Petter Mostad wrote:
> EMC1438 is similar to EMC14x4, but supports four
> more external temperature sensors.
> 
> Signed-off-by: Lars Petter Mostad <lars.petter.mostad@appear.net>

Conversion to the _with_info API is long overdue for this driver
(not mandatory here but it would reduce driver size a lot).

> ---
>  drivers/hwmon/emc1403.c | 119 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 117 insertions(+), 2 deletions(-)
> 
> 
> base-commit: e723f6ca39fb54ae31f79b5af74fe8496308d4de
> 
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index d370efd6f986..1ce01baf7a1e 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -24,12 +24,12 @@
>  #define THERMAL_SMSC_ID_REG	0xfe
>  #define THERMAL_REVISION_REG	0xff
>  
> -enum emc1403_chip { emc1402, emc1403, emc1404 };
> +enum emc1403_chip { emc1402, emc1403, emc1404, emc1408 };

There is no EMC1408, and if there was it might not be compatible with
EMC1438.

The 8-channel chips (emc1428 and emc1438) suppport signed data
and limit registers. This will need to be handled.

I don't know if this also applies to any of the emc144X chips - the
datasheets for those chips are not available to the public. AFAICS all
other chips in the series (i.e., all chips with less than 8 channels)
have unsigned temperature registers.

Guenter