Re: [PATCH v3 2/2] hwmon: add AMD Promontory 21 xHCI temperature sensor support

[Mario Limonciello <mario.limonciello@amd.com>]

On 5/8/26 09:21, Jihong Min wrote:
>> Yes.
>>
>> Please note that you keep top-posting. I don't mind that much, but
>> top-posting is (sometimes strongly) discouraged for linux kernel 
>> discussions.
> 
> Sorry, this is my first kernel contribution and I was not familiar with the
> mailing list convention around top-posting. I will avoid top-posting and 
> use
> inline replies from now on.

Another thing to mention is that you are going too fast between patch 
versions.  All your patches show up in a ton of people's inboxes.

It's great you've gotten feedback on them but I suggest you give it a 
few days or a week between versions to gather more feedback.

If you haven't already; you should take a look at what Sahiko finds on 
your patches too.  Be sure to look at the feedback critically and take 
it with a grain of salt; but it often finds a few nuggets that are 
worthwhile to consider.

Here is the Sahiko link for v4 you can review if you weren't already 
looking at it.

https://sashiko.dev/#/patchset/20260508143910.14673-1-hurryman2212%40gmail.com

> 
> I have addressed the review comments in v4, including runtime PM behavior,
> temp1_label removal, -ENODATA return, the PROM21-specific xHCI PCI glue 
> split,
> and making the PROM21 PCI glue built-in only when enabled. I also 
> adopted the
> naming scheme discussed above:
> 
>    - drivers/hwmon/prom21-xhci.c
>    - CONFIG_SENSORS_PROM21_XHCI
>    - hwmon name: prom21_xhci
> 
> I will send v4 now.
> 
> Sincerely,
> Jihong Min