Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>,
	Li XingYang <yanhuoguifan@gmail.com>
Cc: jdelvare@suse.com, corbet@lwn.net, linux-hwmon@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS
Date: Wed, 4 Dec 2024 06:00:25 -0800	[thread overview]
Message-ID: <76911794-fe8d-411b-bfeb-caa46bc929a6@roeck-us.net> (raw)
In-Reply-To: <CAB95QAQ5CS3Xg2xfPgvOP1LjaXxKtUrjCuo4gv2x=h=-40cBwA@mail.gmail.com>

On 12/4/24 03:31, Eugene Shalygin wrote:
> Hi,
> 
> Sorry for the late reply. This patch is OK with me.
> 

A Reviewed-by: tag would have been helpful.

Guenter

> Best regards,
> Eugene
> 
> On Sun, 1 Dec 2024 at 04:48, Li XingYang <yanhuoguifan@gmail.com> wrote:
>>
>> add asus-ec-sensors support on the mainboard TUF GAMING X670E PLUS
>>
>> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
>> ---
>>   Documentation/hwmon/asus_ec_sensors.rst |  1 +
>>   drivers/hwmon/asus-ec-sensors.c         | 11 +++++++++++
>>   2 files changed, 12 insertions(+)
>>
>> diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
>> index ca38922f4ec5..739636cf7994 100644
>> --- a/Documentation/hwmon/asus_ec_sensors.rst
>> +++ b/Documentation/hwmon/asus_ec_sensors.rst
>> @@ -29,6 +29,7 @@ Supported boards:
>>    * ROG STRIX Z690-A GAMING WIFI D4
>>    * ROG ZENITH II EXTREME
>>    * ROG ZENITH II EXTREME ALPHA
>> + * TUF GAMING X670E PLUS
>>
>>   Authors:
>>       - Eugene Shalygin <eugene.shalygin@gmail.com>
>> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
>> index 381bf117104f..43e54dc513da 100644
>> --- a/drivers/hwmon/asus-ec-sensors.c
>> +++ b/drivers/hwmon/asus-ec-sensors.c
>> @@ -479,6 +479,15 @@ static const struct ec_board_info board_info_zenith_ii_extreme = {
>>          .family = family_amd_500_series,
>>   };
>>
>> +static const struct ec_board_info board_info_tuf_gaming_x670e_plus = {
>> +       .sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
>> +               SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
>> +               SENSOR_TEMP_WATER_IN | SENSOR_TEMP_WATER_OUT |
>> +               SENSOR_FAN_CPU_OPT,
>> +       .mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
>> +       .family = family_amd_600_series,
>> +};
>> +
>>   #define DMI_EXACT_MATCH_ASUS_BOARD_NAME(name, board_info)                      \
>>          {                                                                      \
>>                  .matches = {                                                   \
>> @@ -540,6 +549,8 @@ static const struct dmi_system_id dmi_table[] = {
>>                                          &board_info_zenith_ii_extreme),
>>          DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
>>                                          &board_info_zenith_ii_extreme),
>> +       DMI_EXACT_MATCH_ASUS_BOARD_NAME("TUF GAMING X670E-PLUS",
>> +                                       &board_info_tuf_gaming_x670e_plus),
>>          {},
>>   };
>>
>> --
>> 2.47.1
>>
> 


  reply	other threads:[~2024-12-04 14:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-01  3:47 [PATCH v3 0/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS Li XingYang
2024-12-01  3:47 ` [PATCH v3 1/2] hwmon: (asus-ec-sensors) AMD 600 motherboard add support for fan cpu opt Li XingYang
2024-12-04 11:44   ` Eugene Shalygin
2024-12-04 14:01   ` Guenter Roeck
2024-12-01  3:47 ` [PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS Li XingYang
2024-12-03 11:34   ` Li XingYang
2024-12-04 11:31   ` Eugene Shalygin
2024-12-04 14:00     ` Guenter Roeck [this message]
2024-12-04 14:04   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76911794-fe8d-411b-bfeb-caa46bc929a6@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=corbet@lwn.net \
    --cc=eugene.shalygin@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yanhuoguifan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox