Re: [PATCH v3 2/4] hwmon: (lm90) Use hwmon_notify_event()

Jon Hunter
2022-02-21T16:17:24Z

On 21/02/2022 16:02, Guenter Roeck wrote:

...

>> The platform I see this on does use device-tree and it does have a
>> node for the ti,tmp451 device which uses the lm90 device. This
>> platform uses the device-tree source
>> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts and the tmp451 node
>> is in arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi.
>>
>
> Interesting. It appears that the call to
> devm_thermal_zone_of_sensor_register()
> in the hwmon core nevertheless returns -ENODEV which is not handled
> properly
> in the hwmon core. I can see a number of reasons for this to happen:
> - there is no devicetree node for the lm90 device
> - there is no thermal-zones devicetree node
> - there is no thermal zone entry in the thermal-zones node which matches
>   the sensor

So we definitely have the node for the lm90 device and a thermal-zones
node, but I do not see a thermal-sensor node. Maybe this is what we are
missing?

Jon

--
nvpublic