From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A3EF136983 for ; Sun, 14 Apr 2024 23:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713137036; cv=none; b=DjBYo8MCey78WxhcbtKeCTTQI7todS28AO+1mZaOPttBGO3WIjuhkzCvSsaaRGjdX4hcdL5PIqgKLkc8EMSZ5JcxGuBUjJL8L7JXxxqYKL2HIgEk30nLNU4oCC+tUcyTbC2jfPIxXi5bKeKhn3J8iWqVGb/eK5nY1PUdJauuzaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713137036; c=relaxed/simple; bh=m8igsyuCj+BEZxsNlKY9VUyc9V2pK+X+p2LLBtKZVoU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=fmtM2y0r8IcB9RwykfgE/mjqQGGP+OumcWDfa87O22HIfXbIgWc07+XUbaOjra9jYxAwrB1i1A3ZdQsRUIXKPK+QTvMEBM7b7TploMhrgRHL0aGgkvkbv5vrccdIU0Qsl20AaUBghHn7LbaDxMRzIwIYqeMQTk1w/OwHSa7rcCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VGgRsh8t; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VGgRsh8t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713137034; x=1744673034; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=m8igsyuCj+BEZxsNlKY9VUyc9V2pK+X+p2LLBtKZVoU=; b=VGgRsh8thRckIXN6ua0FMVI00Q2gOHWTCIZ9uZQYuc3+vRlIHqAZmWHi TDNgOhtSlEMxhIfsB0hFPxyMjcK2gpzDbIuTf/9Gyr/WVDPpPrctpnxY5 gtxdYaKpv5HaWU1IBqkdTvek4uvj5RFS9OYdwED3SH7gkDYJ+HFma3eLi o9Vp5gylRUXFmdpjnwMm+u7v3EY22QBA/8CBo8cDHf0JaTPynxW0koYah 9eWsj5DQBTlMFzLWit1MsNnTyyQKZM68BzPtGkVwNR5hOep2qg00yZB41 JqehCQwRox8gjlj/S5/Xlt/rvZJRK9u/1Dn7KnWaIdprDU2DlEeO4uCHN g==; X-CSE-ConnectionGUID: nRHqcpZfSzOueSGhmZO9ng== X-CSE-MsgGUID: mUbP3zZlRruqmPPgqZqdBQ== X-IronPort-AV: E=McAfee;i="6600,9927,11044"; a="8637319" X-IronPort-AV: E=Sophos;i="6.07,202,1708416000"; d="scan'208";a="8637319" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2024 16:23:54 -0700 X-CSE-ConnectionGUID: O9n+fkWZR/igkV2E/zWp2g== X-CSE-MsgGUID: gygYXM4iTFi7ES2U8kKQZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,202,1708416000"; d="scan'208";a="26550470" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2024 16:23:54 -0700 Date: Sun, 14 Apr 2024 16:23:53 -0700 Message-ID: <85cyqrtto6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-gfx@lists.freedesktop.org Cc: Badal Nilawar , Andi Shyti , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , linux-hwmon@vger.kernel.org Subject: Re: [PATCH] drm/i915/hwmon: Get rid of devm In-Reply-To: <20240413001031.481961-1-ashutosh.dixit@intel.com> References: <20240413001031.481961-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Fri, 12 Apr 2024 17:10:31 -0700, Ashutosh Dixit wrote: > > When both hwmon and hwmon drvdata (on which hwmon depends) are device > managed resources, the expectation, on device unbind, is that hwmon will be > released before the drvdata. However, it appears devres does not do this > consistently, so that we occasionally see drvdata being released before > hwmon itself. This results in a uaf if hwmon sysfs is accessed during > device unbind. > > The only way out of this seems to be do get rid of devm_ and release/free > everything explicitly during device unbind. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 > Signed-off-by: Ashutosh Dixit Please don't review this patch yet, I will send a v2 tomorrow. Please review the v2. Thanks.