From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: devicetree@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, "Armin Wolf" <W_Armin@gmx.de>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"René Rebe" <rene@exactcode.de>
Subject: Re: [PATCH v2 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings
Date: Fri, 31 May 2024 15:14:17 +0200 [thread overview]
Message-ID: <85e49c2f-e69d-4bd4-917f-0a3b12d65509@kernel.org> (raw)
In-Reply-To: <f53deeb2-bc08-4363-b8d0-ff3987409ca7@roeck-us.net>
On 31/05/2024 15:09, Guenter Roeck wrote:
> On 5/31/24 01:15, Krzysztof Kozlowski wrote:
>> On 31/05/2024 00:39, Guenter Roeck wrote:
>>> Add device tree bindings for the SPD hub present in DDR5 modules.
>>>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> ...
>>
>>> +title: JEDEC JESD300-5B (SPD5118) compatible DDR5 SPD hub
>>> +
>>> +maintainers:
>>> + - Guenter Roeck <linux@roeck-us.net>
>>> +
>>> +description: |
>>> + JEDEC JESD300-5B.01 SPD5118 Hub and Serial Presence Detect
>>> + https://www.jedec.org/standards-documents/docs/jesd300-5b01
>>> +
>>> +select:
>>> + properties:
>>> + compatible:
>>> + const: jedec,spd5118
>>
>> Why do you need the select? This s needed for cases with multiple
>> bindings using parts of compatible list. I don't see the case here so far.
>>
>
> Sorry, I am not a devicetree expert, I don't really know what I am doing,
> and just copied this from some other binding. I'll try to find a better
> example. Actually, I'll just add the binding to trivial devices.
Sounds good.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-31 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 22:39 [PATCH v2 2/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-05-30 22:39 ` [PATCH v2 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings Guenter Roeck
2024-05-31 8:15 ` Krzysztof Kozlowski
2024-05-31 13:09 ` Guenter Roeck
2024-05-31 13:14 ` Krzysztof Kozlowski [this message]
2024-05-30 22:39 ` [PATCH v2 2/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-05-30 22:39 ` [PATCH v2 3/3] hwmon: (spd5118) Add suspend/resume support Guenter Roeck
2024-05-30 22:51 ` [PATCH v2 2/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85e49c2f-e69d-4bd4-917f-0a3b12d65509@kernel.org \
--to=krzk@kernel.org \
--cc=W_Armin@gmx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=rene@exactcode.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox