From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B91EEB64D9 for ; Mon, 3 Jul 2023 01:48:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbjGCBsn (ORCPT ); Sun, 2 Jul 2023 21:48:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjGCBsn (ORCPT ); Sun, 2 Jul 2023 21:48:43 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D66193 for ; Sun, 2 Jul 2023 18:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688348922; x=1719884922; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=VZGSMMmfhlV+/+u06kQ5LO0xoO+O7TvJI99kAUGGxbE=; b=jmF0F4EZOYe3OSerb77mX2JOeeGJ9h03/550jc8P/EGjwDIA3DEGu9cH O2hfAYX4k9IssKUZqIH+pFiBJvEspaL9EPnEKVwKEJ3Ft6mCPi/58P7nY wO+UvAjLG3gfixyZ4Ue292naTA+2AUJxQlcv15wCj9D2b2iRNocZfqUbc yaNrO4Jex9LzrlgIrp/h5E+vc8qwpDdswE5dXmqyY2tH+QTCx87YsYOOm pnCKoG9UWalMndcBEJLrulfkXtjAW5nXeYdxcoRx4XVopP4xgYavsYL7c zx3ye8+qotNcn/z5LsPdPzqZZRa14iJJ7/7pXzR6NciaGKoncvNdRWPUb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="393508767" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="393508767" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 18:48:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="964990481" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="964990481" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.255.228.125]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 18:48:40 -0700 Date: Sun, 02 Jul 2023 18:48:20 -0700 Message-ID: <871qhpepej.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Guenter Roeck Cc: Badal Nilawar , intel-xe@lists.freedesktop.org, linux-hwmon@vger.kernel.org, anshuman.gupta@intel.com, andi.shyti@linux.intel.com, riana.tauro@intel.com, matthew.brost@intel.com Subject: Re: [PATCH v2 0/6] Add HWMON support for DGFX In-Reply-To: <4b71ba43-4cbb-0840-a46a-3fe4518254d0@roeck-us.net> References: <20230627183043.2024530-1-badal.nilawar@intel.com> <87ilb385fv.wl-ashutosh.dixit@intel.com> <5aa93c3a-a4c5-9ca3-6ecd-38cef9f59605@roeck-us.net> <874jmme276.wl-ashutosh.dixit@intel.com> <873526dpl3.wl-ashutosh.dixit@intel.com> <4b71ba43-4cbb-0840-a46a-3fe4518254d0@roeck-us.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sun, 02 Jul 2023 13:51:40 -0700, Guenter Roeck wrote: > > On 7/2/23 13:29, Dixit, Ashutosh wrote: > > > Of course people might have been abusing the deprecated API's (or NULL chip > > parameter) but to me it seems there is also some legitimate use for them. > > > > You still neglect to explain what you think that legitimate use would be. To me "drivers/gpu/drm/amd/pm/amdgpu_pm.c" is a legitimate use case which doesn't use chip_info (both standard and custom hwmon attributes are defined without using chip_info). "drivers/gpu/drm/i915/i915_hwmon.c" has all this extra code related to chip_info/channel_info which is not needed. i915 could well move to the amdgpu model and that would reduce i915 code. That is what I was originally proposing for this new patch series. Ashutosh