From: Peter Korsgaard <peter@korsgaard.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property
Date: Sat, 11 Jan 2025 19:24:09 +0100 [thread overview]
Message-ID: <874j25dx9y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <f6ee420b-7c3f-4a21-831b-619fe38408b5@roeck-us.net> (Guenter Roeck's message of "Sat, 11 Jan 2025 09:15:05 -0800")
>>>>> "Guenter" == Guenter Roeck <linux@roeck-us.net> writes:
Hi,
>> Guenter, what do you say? This way we don't need any new device tree
>> properties. I personally find it less clear than a default-pwm property,
>> but oh well.
>>
> I would not call that "default". It is more along the line of
> "If available, use highest cooling level as maximum allowed".
Sorry, what are you referring to exactly? The commit message? The change
is about the default/initial pwm setting, there is nothing disallowing
user space to increase it afterwards?
> Other than that, I don't like it, but since it looks like we
> won't get approval for the devicetree property, I'd say go for it.
Great, then we agree! I'll send a v5 then once it is clear what your
comment above refers to.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2025-01-11 18:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 10:14 [PATCH v4 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Peter Korsgaard
2025-01-03 10:14 ` [PATCH v4 2/2] hwmon: (pwm-fan): Make default PWM duty cycle configurable Peter Korsgaard
2025-01-03 19:58 ` [PATCH v4 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Rob Herring
2025-01-05 16:10 ` Peter Korsgaard
2025-01-06 17:38 ` Rob Herring
2025-01-06 18:32 ` Guenter Roeck
2025-01-10 20:06 ` Peter Korsgaard
2025-01-11 17:15 ` Guenter Roeck
2025-01-11 18:24 ` Peter Korsgaard [this message]
2025-01-11 22:45 ` Guenter Roeck
2025-01-05 16:42 ` Guenter Roeck
2025-01-05 17:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j25dx9y.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox