From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA08C433EF for ; Tue, 21 Jun 2022 06:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346040AbiFUGly (ORCPT ); Tue, 21 Jun 2022 02:41:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346045AbiFUGly (ORCPT ); Tue, 21 Jun 2022 02:41:54 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71A011929E for ; Mon, 20 Jun 2022 23:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655793711; x=1687329711; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=wSQZKdR2/Orl1YwAA4O8uFgs/DwhDSwHJD8XGUElNaA=; b=buAtbGzGBJociOyerWWpuIGM1WoDhMESusCjS3sVrUZc1IJkMheY/+mN kbxzwq/x4ikcoh7RvH5qLDej/d6k99j3tnVkqJDyrOV+D16KHx9N1zm3L FcCQRQhDW72CVxxwIhYkHUVtv2wSHCqkcp93inlU7lzBDac5RRv1wECx+ 8LK8tO/Lx9OLdvSCSZ2JeE3z0HT5UBgv3uOVA6BzK1Jg0lY6mXVNh6UM4 6vUaU4wy5UdkoEFeRCGTYcoRGTpxV5aroUfhqAWa3TW8vwDv6zXJZoy7N AJHCGpw+EKCvKYXa476Ansr1M1uwihiD/2gPOeWNztBG4JUb9X1misBxb A==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="366365026" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="366365026" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 23:41:51 -0700 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="585161215" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.238.99]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 23:41:50 -0700 Date: Mon, 20 Jun 2022 23:41:50 -0700 Message-ID: <87a6a6v7pt.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Guenter Roeck Cc: Badal Nilawar , intel-gfx@lists.freedesktop.org, anshuman.gupta@intel.com, jon.ewins@intel.com, riana.tauro@intel.com, linux-hwmon@vger.kernel.org Subject: Re: [PATCH 4/4] drm/i915/hwmon: Add HWMON energy support In-Reply-To: References: <20220620204649.894703-1-badal.nilawar@intel.com> <20220620204649.894703-5-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, 20 Jun 2022 14:04:53 -0700, Guenter Roeck wrote: > > > @@ -141,9 +282,12 @@ i915_power1_max_default_show(struct device *dev, struct device_attribute *attr, > > static SENSOR_DEVICE_ATTR(power1_max_default, 0444, > > i915_power1_max_default_show, NULL, 0); > > +static SENSOR_DEVICE_ATTR(energy1_input, 0444, > > + i915_energy1_input_show, NULL, 0); > > static struct attribute *hwmon_attributes[] = { > > &sensor_dev_attr_power1_max_default.dev_attr.attr, > > + &sensor_dev_attr_energy1_input.dev_attr.attr, > > Why not use HWMON_E_INPUT ? Agreed, we will investigate switching to this. I also had a similar comment about this here: https://patchwork.freedesktop.org/patch/487020/?series=104278&rev=1 Thanks. -- Ashutosh