From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E7AC54EE9 for ; Wed, 21 Sep 2022 00:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbiIUAY7 (ORCPT ); Tue, 20 Sep 2022 20:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbiIUAY4 (ORCPT ); Tue, 20 Sep 2022 20:24:56 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA3622B199 for ; Tue, 20 Sep 2022 17:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663719894; x=1695255894; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=V53TZtPrnnK3O6iAhed5BlvQPyc5eE8HInkDMBNImEE=; b=WNrghLAOZ4nfg/K4egn5I4V0vCgxO7XHtbYvrX/yqP5crf+1SandM562 xEKlpprDVo+2jA98EYkZHIIiB7oqzHCiywOMICTTQcHjfSF/Mv5dKzBJ8 3fEO+EYvt2AQA7/d2ZfiqujAj7sYaFXehjZUMNzV13bbecrIguPeUy1Ot 0GdwV7KIjYWV4iquXVJ3AmNtBmhNWUOSMp1F73n7ZpOD+kTqYeqlNJJer eWAnKwrKNsw+1JOVytOtfWaZsANpugz8giox5SWlrCToyNeEc0thg/8mk UWSwmQREMaPkA2Dczrb86nCwUKMgIUomWxEP8XXNvVClpGZGLqStBfqW/ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10476"; a="326166727" X-IronPort-AV: E=Sophos;i="5.93,332,1654585200"; d="scan'208";a="326166727" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 17:24:54 -0700 X-IronPort-AV: E=Sophos;i="5.93,332,1654585200"; d="scan'208";a="947911062" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.57.76]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 17:24:52 -0700 Date: Tue, 20 Sep 2022 17:24:51 -0700 Message-ID: <87edw5d164.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Tvrtko Ursulin Cc: Badal Nilawar , intel-gfx@lists.freedesktop.org, linux-hwmon@vger.kernel.org, Riana Tauro , Jon Ewins Subject: Re: [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage In-Reply-To: References: <20220825132118.784407-1-badal.nilawar@intel.com> <20220825132118.784407-5-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Tue, 13 Sep 2022 01:50:08 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 25/08/2022 14:21, Badal Nilawar wrote: > > From: Dale B Stimson > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > index 9a2d10edfce8..03d71c6869d3 100644 > > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > +++ b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > @@ -25,3 +25,11 @@ Contact: dri-devel@lists.freedesktop.org > > Description: RO. Card default power limit (default TDP setting). > > Only supported for particular Intel i915 graphics > > platforms. > > + > > +What: /sys/devices/.../hwmon/hwmon/energy1_input > > +Date: June 2022 > > +KernelVersion: 5.19 > > Date and kernel version will need updating throughout I think. > > But why I am here actually is to ask if there are plans to make > intel_gpu_top support this? It would be nice to have since it reports power > for integrated. There were no plans but now Riana has an IGT patch series which exposes a unified inteface for rapl/hwmon (igfx/dgfx): https://patchwork.freedesktop.org/series/108185/ So perhaps we can either have intel_gpu_top use this IGT lib or if it doesn't, copy some functions to intel_gpu_top. Thanks. -- Ashutosh