From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 220B8ECAAD1 for ; Tue, 30 Aug 2022 05:34:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbiH3Fez (ORCPT ); Tue, 30 Aug 2022 01:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiH3Fey (ORCPT ); Tue, 30 Aug 2022 01:34:54 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82C88265C for ; Mon, 29 Aug 2022 22:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661837692; x=1693373692; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=n0bN2e0WKifglh77Cpb5jIjBhyfy1+lrG2pX+4TM2fE=; b=nEEzLMhGyCPqCjIjz539T2MGgjbw2c2xq13ro06t27WcbSJkkveNId1h t+1SiaGPUV5IJAWi7kguir8NI6jfUzdTPVSPC4wUFt2WyAjrkJIcq783i 5IRn4pc93/84uOFAuy+v+hGaWunrWJRK2OolDqXx/Fwg/tzoy4Eese2g+ USnQ9BlRyTmLKjhHOJ8oGBz+7BtU8PCnDzCU0g5+5zCHAIY8QRrQ55awX KSpo1Z1uyuA2xiRKOvxYiGaifCaLZkSwqvFMY2CDrPkEHEttPFoc5AB9G WKv+CWhSCp9JO/tYuHbdEuHThoyFk+LwM6z20RHLKilRfYBleJ5ZDhdGT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="292662096" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="292662096" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 22:34:52 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672690425" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.252.143.205]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 22:34:51 -0700 Date: Mon, 29 Aug 2022 22:34:02 -0700 Message-ID: <87h71uz451.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Badal Nilawar Cc: , , , , Subject: Re: [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV In-Reply-To: <20220825132118.784407-8-badal.nilawar@intel.com> References: <20220825132118.784407-1-badal.nilawar@intel.com> <20220825132118.784407-8-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Thu, 25 Aug 2022 06:21:18 -0700, Badal Nilawar wrote: > > From: Dale B Stimson > > Extend hwmon power/energy for XEHPSDV especially per gt level energy > usage. A couple of very minor nits below which need to be fixed. But otherwise this patch is: Reviewed-by: Ashutosh Dixit > diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c > index b8ac52f07681..76d73216c54e 100644 > --- a/drivers/gpu/drm/i915/i915_hwmon.c > +++ b/drivers/gpu/drm/i915/i915_hwmon.c > @@ -12,6 +12,7 @@ > #include "i915_reg.h" > #include "intel_mchbar_regs.h" > #include "intel_pcode.h" > +#include "gt/intel_gt.h" > #include "gt/intel_gt_regs.h" > > /* > @@ -21,7 +22,7 @@ > * - curr - milliamperes > * - energy - microjoules > */ > -#define SF_TIME 1000 > +#define SF_TIME 1000 This change should not be in this patch, it seems an unnecessary space has been inserted. > @@ -622,6 +690,10 @@ void i915_hwmon_register(struct drm_i915_private *i915) > struct i915_hwmon *hwmon; > struct device *hwmon_dev; > struct hwm_drvdata *ddat; > + struct hwm_drvdata *ddat_gt; > + struct intel_gt *gt; > + const char *ddname; Variable is not needed, let's delete it and directly use ddat_gt->name. > void i915_hwmon_unregister(struct drm_i915_private *i915) > { > struct i915_hwmon *hwmon; > struct hwm_drvdata *ddat; > + struct intel_gt *gt; > + int i; > > hwmon = fetch_and_zero(&i915->hwmon); > if (!hwmon) > return; > > ddat = &hwmon->ddat; > + > + for_each_gt(gt, i915, i) { > + struct hwm_drvdata *ddat_gt; > + > + ddat_gt = hwmon->ddat_gt + i; > + > + if (ddat_gt->hwmon_dev) { > + hwmon_device_unregister(ddat_gt->hwmon_dev); > + ddat_gt->hwmon_dev = NULL; No need to set to NULL, we are doing 'kfree(hwmon)' below, let's just delete this line. Thanks. -- Ashutosh