From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ECBC07E9D for ; Sat, 24 Sep 2022 03:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233212AbiIXD6p (ORCPT ); Fri, 23 Sep 2022 23:58:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233053AbiIXD6n (ORCPT ); Fri, 23 Sep 2022 23:58:43 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60FA4EDD34 for ; Fri, 23 Sep 2022 20:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663991922; x=1695527922; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=61PzOGJY1pggSlQOywIUKZGPTSgOdKoMbwRs82UQh6s=; b=ginVQ+xlPjp97jMqnLpBlcbDHzyp06MkWjm0hvQbJXDtRA+Jd8n2jwK8 GJnCeeEbskA/Fh+BUUw69vWMMH8ZkIvdYRErT6JP8OZVHgPGinJact9D3 G0bwCnlidMWNjWppWP4tLE7GOiOq8qDwk6Zpljl8gjWABXl+qtjCJFeLw CJEVHBJ7BEZpfgtwata7w5Y5oeAavbgFmEqWCBtOxyfW6T5zzXqvg09PX 0Y/qbayI9pggY3E/SCpgs0vJDx+p3jBQ5MrVGFohlcWTk9n56RXtxnQlf 8edBUuucwep9Hki9phOJ2grbAVW8obfxAEeAX1Wh/Yod0CKf7nLcQzQsk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10479"; a="283852324" X-IronPort-AV: E=Sophos;i="5.93,341,1654585200"; d="scan'208";a="283852324" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 20:58:41 -0700 X-IronPort-AV: E=Sophos;i="5.93,341,1654585200"; d="scan'208";a="949255411" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.252.138.221]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 20:58:40 -0700 Date: Fri, 23 Sep 2022 20:58:40 -0700 Message-ID: <87o7v58lu7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Badal Nilawar Cc: , , , , , , , Subject: Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval In-Reply-To: <20220923195643.2376927-7-badal.nilawar@intel.com> References: <20220923195643.2376927-1-badal.nilawar@intel.com> <20220923195643.2376927-7-badal.nilawar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, 23 Sep 2022 12:56:42 -0700, Badal Nilawar wrote: > > From: Ashutosh Dixit > > Expose power1_max_interval, that is the tau corresponding to PL1. I think let's change the above sentence to: "Expose power1_max_interval, that is the tau corresponding to PL1, as a custom hwmon attribute". This is the only custom attribute we are exposing so better to mention this in the commit message I think. Thanks. -- Ashutosh