Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller

Lee Jones
2020-04-29T06:27:35Z

On Tue, 28 Apr 2020, Andy Shevchenko wrote:

> On Tue, Apr 28, 2020 at 04:43:24PM +0200, Michael Walle wrote:
> > Am 2020-04-28 14:50, schrieb Andy Shevchenko:
> > > On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote:
> > > > This patch adds core support for the board management controller found
> > > > on the SMARC-sAL28 board. It consists of the following functions:
> > > > - watchdog
> > > > - GPIO controller
> > > > - PWM controller
> > > > - fan sensor
> > > > - interrupt controller
> > >
> > > ...
> > >
> > > > obj-$(CONFIG_MFD_STMFX) += stmfx.o
> > > >
> > > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o
> > > > +
> > > > +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o
> > >
> > > Perhaps keep an order?
> >
> > I don't see any order in that makefile. Looked to me like every new
> > file was added at the end.
>
> Okay, just didn't note from above context.

Yes, this is historical. I've been meaning to visit this for ~7 years!

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog