From: Eric Anholt <eric@anholt.net>
To: Guenter Roeck <linux@roeck-us.net>,
Stefan Wahren <stefan.wahren@i2se.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, "Noralf Trønnes" <noralf@tronnes.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Phil Elwell" <phil@raspberrypi.org>,
linux-hwmon@vger.kernel.org, "Jean Delvare" <jdelvare@suse.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 3/6] hwmon: Add support for RPi voltage sensor
Date: Thu, 17 May 2018 18:25:31 +0100 [thread overview]
Message-ID: <87sh6qdwj8.fsf@anholt.net> (raw)
In-Reply-To: <20180517164320.GA30364@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
Guenter Roeck <linux@roeck-us.net> writes:
> On Wed, May 16, 2018 at 09:59:01PM +0200, Stefan Wahren wrote:
>> Hi Guenter,
>>
>> > Guenter Roeck <linux@roeck-us.net> hat am 16. Mai 2018 um 20:21 geschrieben:
>> >
>> >
>> > On Wed, May 16, 2018 at 03:37:04PM +0200, Stefan Wahren wrote:
>> > > Currently there is no easy way to detect under-voltage conditions on a remote
>> > > Raspberry Pi. This hwmon driver retrieves the state of the under-voltage sensor
>> > > via mailbox interface. The handling based on Noralf's modifications to the
>> > > downstream firmware driver. In case of an under-voltage condition only an entry
>> > > is written to the kernel log.
>> > >
>> >
>> > My major concern is how this is displayed with the 'sensors' command.
>> > Can you test and report ?
>>
>> I get the following output:
>> rpi_volt-isa-0000
>> Adapter: ISA adapter
>> in0: N/A
>>
> Ok, that works.
Thanks for the quick review on this, Guenter! This driver is going to
help save a lot of people debugging time on rpis in the upstream kernel.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-05-17 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 13:37 [PATCH RFC 0/6] hwmon: Add support for Raspberry Pi voltage sensor Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 1/6] ARM: bcm2835: Add GET_THROTTLED firmware property Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 2/6] dt-bindings: hwmon: Add Raspberry Pi voltage sensor Stefan Wahren
2018-05-16 14:23 ` Robin Murphy
2018-05-16 17:51 ` Eric Anholt
2018-05-16 14:52 ` Guenter Roeck
2018-05-16 13:37 ` [PATCH RFC 3/6] hwmon: Add support for RPi " Stefan Wahren
2018-05-16 13:51 ` Robin Murphy
2018-05-16 18:05 ` Guenter Roeck
2018-05-16 18:23 ` Robin Murphy
2018-05-16 18:21 ` Guenter Roeck
2018-05-16 19:59 ` Stefan Wahren
2018-05-17 16:43 ` Guenter Roeck
2018-05-17 17:25 ` Eric Anholt [this message]
2018-05-16 13:37 ` [PATCH RFC 4/6] ARM: bcm2835_defconfig: Enable " Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 5/6] ARM: multi_v7_defconfig: " Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 6/6] arm64: defconfig: " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh6qdwj8.fsf@anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=noralf@tronnes.org \
--cc=phil@raspberrypi.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox