From: Guenter Roeck <linux@roeck-us.net>
To: Tabrez Ahmed <tabreztalks@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
david.laight.linux@gmail.com, me@brighamcampbell.com,
shuah@kernel.org
Subject: Re: [PATCH v6 3/3] hwmon: (ads7871) Use DMA-safe buffer for SPI writes
Date: Sat, 2 May 2026 11:23:47 -0700 [thread overview]
Message-ID: <8f4363a4-b05a-4e42-8868-e7b611fd0dda@roeck-us.net> (raw)
In-Reply-To: <20260502020844.110038-4-tabreztalks@gmail.com>
On Sat, May 02, 2026 at 07:38:44AM +0530, Tabrez Ahmed wrote:
> The driver currently passes a stack-allocated buffer to spi_write(),
> which is incompatible with DMA on systems with CONFIG_VMAP_STACK
> enabled.
>
> Move the transfer buffer into the driver's private data structure
> to ensure it is DMA-safe. Since this shared buffer now requires
> serialization, this change depends on the previous commit which
> migrated the driver to the hwmon 'with_info' API.
>
> While moving the logic, also:
> - Corrected the sign extension for 14-bit data by casting to s16.
> - Scaled the output to millivolts (2500mV full scale
> ) to comply with the hwmon ABI.
>
> Signed-off-by: Tabrez Ahmed <tabreztalks@gmail.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-05-02 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 2:08 [PATCH v6 0/3] hwmon: (ads7871) Fix endianness and modernize driver Tabrez Ahmed
2026-05-02 2:08 ` [PATCH v6 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads Tabrez Ahmed
2026-05-02 18:18 ` Guenter Roeck
2026-05-02 2:08 ` [PATCH v6 2/3] hwmon: (ads7871) Convert to hwmon_device_register_with_info Tabrez Ahmed
2026-05-02 18:18 ` Guenter Roeck
2026-05-02 2:08 ` [PATCH v6 3/3] hwmon: (ads7871) Use DMA-safe buffer for SPI writes Tabrez Ahmed
2026-05-02 18:23 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f4363a4-b05a-4e42-8868-e7b611fd0dda@roeck-us.net \
--to=linux@roeck-us.net \
--cc=david.laight.linux@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=shuah@kernel.org \
--cc=tabreztalks@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox