From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A12514E56CC for ; Fri, 18 Sep 2026 12:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789734573; cv=none; b=AEXu5jeS2n/NDdLSj7j24CWRVxPwc0S8MSb34/1X9qx+7zqMKGjs+98vWSF0wVKI+9x0OjDNkWON1elRzWfffl7LaGC+L2iS7RzKG4LhNIXx+8VfR4/5zD4pUyo9jSiVK0hrfSx+NZSPX3piK9Br9ckKEt/mz0tWJpQtqCu7iN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789734573; c=relaxed/simple; bh=nSwLQCSCwANRAsqBSnLcGPN2DlqL+AmkhbMOH92cits=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bVnPceCs64bRWqPvuY1Htoy5RGYzpI96DTXCjUHd+/843DfthzvPohdE16P10+wsUqbq7/3Wiipwqr7ByH42bmKFMKAmRlGrVzTcwPVXJp6WqFLABQIufZTZZQZ0nRBvREczSvi9kF0NniPiq0vb8InjHThYB4jc1tixninrMGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FR4AK7oq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ECKO2vZt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FR4AK7oq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ECKO2vZt" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68I9dgG71213630 for ; Fri, 18 Sep 2026 12:29:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SmcR5sjFJKe+lRs3BkZxPHezCF6SKm8GZJtIuEc4KDs=; b=FR4AK7oqDNJSD479 xKKE92BS4uXWQW3jNtDReDJGnmwyp5z44hNW3w2JgIVliYHTrSu/CHYXw7fxhS3j 4LxI+JE8yFcXkfwvd9Hg9JqjoWX7hXTl216Qt2FXksAB+1ArIfxB4K1GmPY7UHHW aMHoUHAOaE/w/1HqWHmR2cnQmXf1OC6IgjfdSpid3vHkYkGgZVqCz+OXrJybsHsm bJlAdgGLGYdHh/f0mmt7nmcV+jvfPJRqYl8weOWrJGWhDKCc/hkzBLVx271cmyIH cpgJMV+7JEx3H/ahIz3paRPX99ohIbMbErP/g3vZKKAQiuNDMwa5G0pDLl5kRmT2 FEnLXw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4grrg434u2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 18 Sep 2026 12:29:30 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-90e8e3e6ca0so620446d6.3 for ; Fri, 18 Sep 2026 05:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789734570; x=1790339370; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SmcR5sjFJKe+lRs3BkZxPHezCF6SKm8GZJtIuEc4KDs=; b=ECKO2vZtBmj1LVoQHW0Fnl0dT498AUbbCLvWUhIuTk7FHj89xTbg4mM3+Jo1HA2TCZ gt7NhZGKlqy9RkOML53nhYDEB9ri8PCBh1CCkHNLW2+2ZiAiy2/UO3LDt7vCsac1bs4v S9UKfvyNjsR19hmwNvzSJPYrb3neTpMYnZ21/1ZHAxhaEUfCsjW/PSN6v4T/TAhTcQwS Wi06FtdFAccsgxIFs7hODvQ/2nOUJxPUSlBzSHULxFwWCw9DCV6SeG+Nvw2XmRqy8M4C uFPA5NOfuyY3FRt8tx9+C6h/rGzjOvwA55HIvbiTXtG1Le8ge43Zr3MexlPJB9J4dFgn Xybg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789734570; x=1790339370; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SmcR5sjFJKe+lRs3BkZxPHezCF6SKm8GZJtIuEc4KDs=; b=YX0W0lHIyEUpRDkAeNNca9fwjZD44O1R6mtB6DT3+UkgZoMMCy+kHcx1exUVIKvHn/ 5C9NtgHfklU+88+YTyj7zY3KPStp83acBrk7xyi/rIvRpFo4bFtyt/NhFIfif/OdvZXU 2JnIu1RXs+IxKW4jEki/sUe/2wdd3xCv1GYm9IRnf5XII9oHwTEztfeBYzvB5ex/r3DN 4HymOpJ8m/2wi4YPv+6Zh8BWqsfq7lieo8ktCgMgIx3FwcC++W8SEYa99LtuFwj0q87B xYLV7BF5ZIT5MtF2pkNrcz5Df9uBoYfisGUSHnLiiBRK/L73Q2NhXbpJQISgmFlSig47 dz2A== X-Forwarded-Encrypted: i=1; AKwUvBx7i21DMy/dTlQpSmT+r2ZpwIR72EEamxRrTwGsVfk4khbjgrDAmJqoNLUTYEIoCWyI3HJ1AuClP5lQ0g==@vger.kernel.org X-Gm-Message-State: AFuF++mENU1d/ZRQgeg0fgYRZYt0uTUm1vLuJn5RP4AXYigwSTap0FAP TA010bMqHrllE0TbmAJDAN+C4mdl2Z2XqTstAkbb9/KvJzlz2VTqddS+ZXihKASoM7mgWPK4M3a LJ8oDoY/n08tLUkLXaoPQ/9gMwiW0NhwfsmlwKxRO9T6NRVIxnZn56AUK8ryqoX6nZykEknR6vg == X-Gm-Gg: AYBFou3LFSH1Uucbqgg3aBFB6wM6URr6uAv7LXNjEcx+rk1QFrh1ftEhRUHnGQ2yhVx KB4GVKAjY9jLXgpdLCVxweHREBfqLEjhq8hQcMIBVSTjAoIyfsb7SP4p4GVcFWcbjLhlWzjFUMD upgaoeunUZAOYoEsdUWeVD3ez+iJLrob6vzECMF/QVmrS659F3xf7h0BtGDkF4th5sBj/ZX//GE fdr5y89jMvobbZaq2cGCUw+FKgcipHw2gnAdAfvfUWlxb0Sll0BHYemYmPkjUPW/0Xxv5YjHhK/ ZMWccNZ2Mocl5TZPxMtUpVjXHUn/QZqr4mQM00qLICG61h12peydnVqRBN9ReIuQCq4sB+ixek3 jN8iRPfwJtASM22TRNFe1Cw== X-Received: by 2002:a05:6214:21c7:b0:90c:c716:91b5 with SMTP id 6a1803df08f44-91256ef5ad8mr31423516d6.2.1789734569935; Fri, 18 Sep 2026 05:29:29 -0700 (PDT) X-Received: by 2002:a05:6214:21c7:b0:90c:c716:91b5 with SMTP id 6a1803df08f44-91256ef5ad8mr31423026d6.2.1789734569451; Fri, 18 Sep 2026 05:29:29 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a1bb423fdsm49488466b.27.2026.09.18.05.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 05:29:28 -0700 (PDT) Message-ID: <92b7a87a-c086-48d1-8487-883dda7c4d70@oss.qualcomm.com> Date: Fri, 18 Sep 2026 14:29:25 +0200 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: embedded-controller: Add ASUS Zenbook A16 EC To: Krzysztof Kozlowski , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Guenter Roeck , Bjorn Andersson , Abel Vesa , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260917-topic-asus_ec-v1-0-373516d347ae@oss.qualcomm.com> <20260917-topic-asus_ec-v1-1-373516d347ae@oss.qualcomm.com> <20260918-objective-okapi-from-neptune-cbcabd@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260918-objective-okapi-from-neptune-cbcabd@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hL2bK7X_F8uGvCFWiVCZgnE4NOF2R--e X-Authority-Analysis: v=2.4 cv=ZO9CCn7b c=1 sm=1 tr=0 ts=6aad2eaa cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=osjX1abir8ybeEd1uJ4A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: hL2bK7X_F8uGvCFWiVCZgnE4NOF2R--e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE4MDE3NiBTYWx0ZWRfXwG4SaOQk0DsN nuEtWRN4jlLwTTxGkOhY7LYEFxbtVtZmk47HO3AVxEXgCn4xvWXgUyVEMjgUOaQoUgxdXBdDx1+ DdF/Wkg4Rn42R3Tyxo6lq2IjNi9WH1yUcJNv4Gv145uYnQaaE5UiKyftDvKu5NjUlS8uZGWcA1u eZxhqP3WWZ4Dt6a/RG6GxzmY+fKRY+Gu2Lll/qaDsnBUQKhxubaPcQNuEZk3McwoJZ+dKlXGWou X4LopcVkeZn3u00cM8j7mAn4J0G4hSAOY3RT2JVGko3+Xk60zLE1+8eeDdiJ/VFk2rPiKI/OLw+ 5HdTbX51OUfSWbyL8sY4dfkv8xTHsTgi1q3O5z1evodC7kaoiMcOoODhTBXBPJnkZJ4ktPmJp+s Q2p0Dq8HSD5PvrlZzN4LdlCM85Q+m9LJhxNZ6/mBTTixuKFsH6OP5j9g03QbPBkNQt/cv+ltH+M injtgnGRMGxjAuIc58w== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE4MDE3NiBTYWx0ZWRfXzgks9uRu6z6I PNOtFAx6rvWxBe54bimKMZNvsVZlivRyeA8+2Mg+SCg1gvX7vXCdAiOxueohXw+uub2ys9jvgwH n38I6KX6NhujlS31T9u7tRkeDcmYFFk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-18_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609180176 On 9/18/26 1:34 PM, Krzysztof Kozlowski wrote: > On Thu, Sep 17, 2026 at 12:54:56PM +0200, Konrad Dybcio wrote: >> +description: >> + The Qualcomm Snapdragon X2 series-based ASUS Zenbook A16 (and similar >> + machines) come with a custom EC firmware, loosely based on the >> + Qualcomm reference ("Hamoa CRD EC") implementation, with a lot of >> + customization. >> + >> +properties: >> + compatible: >> + enum: >> + - asus,zenbook-a14-ux3407na-ec >> + - asus,zenbook-a16-ux3607oa-ec >> + >> + reg: >> + const: 0x76 >> + >> + interrupts: >> + maxItems: 1 >> + >> + "#thermal-sensor-cells": >> + const: 1 >> + >> + wakeup-source: true >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - '#thermal-sensor-cells' >> + - wakeup-source > > Wakeup source should not be required. If it is, then it is completely > implied by compatible and there is no need for DT property, right? I suppose it's not *required* but it's highly desirable.. should I just drop it from the required list? Konrad