Re: [PATCH v4 2/3] hwmon: ltc4283: Add support for the LTC4283 Swap Controller

[Guenter Roeck <linux@roeck-us.net>]

On 12/15/25 00:20, Tomas Melin wrote:
> Hi,
> 
> On 04/12/2025 18:15, Nuno Sá via B4 Relay wrote:
>> From: Nuno Sá <nuno.sa@analog.com>
>>
>> Support the LTC4283 How Swap Controller. The device features programmable
> 
> I think You mean hot swap controller?
> 
>> current limit with foldback and independently adjustable inrush current to
>> optimize the MOSFET safe operating area (SOA). The SOA timer limits MOSFET
>> temperature rise for reliable protection against overstresses.
>>
>> An I2C interface and onboard ADC allow monitoring of board current,
>> voltage, power, energy, and fault status.
>>
>> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
>> ---
>>   Documentation/hwmon/index.rst   |    1 +
>>   Documentation/hwmon/ltc4283.rst |  266 ++++++
>>   MAINTAINERS                     |    1 +
>>   drivers/hwmon/Kconfig           |   12 +
>>   drivers/hwmon/Makefile          |    1 +
>>   drivers/hwmon/ltc4283.c         | 1719 +++++++++++++++++++++++++++++++++++++++
>>   6 files changed, 2000 insertions(+)
>>
> 
> This is quite a big patch, I wonder would it ease review to try to add a
> minimalistic implementation and after that add new features one by one...
> 

Please don't. I'll end up being the one person who will have to review it,
and those piece by piece driver submissions often end up taking much more time
to review than a single patch because the initial pieces miss the big picture.

Guenter