From: Guenter Roeck <linux@roeck-us.net>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: chipcap2: drop cc2_disable() in the probe and return dev_err_probe()
Date: Tue, 13 Aug 2024 08:53:07 -0700 [thread overview]
Message-ID: <95a73570-0ea9-4396-866e-ffb6fc8a2ba0@roeck-us.net> (raw)
In-Reply-To: <20240813-chipcap2-probe-improvements-v2-1-e9a2932a8a00@gmail.com>
On Tue, Aug 13, 2024 at 12:59:53AM +0200, Javier Carrasco wrote:
> There is no need to actively disable a regulator that has not been
> enabled by the driver, which makes the call to cc2_disable() in the
> probe function meaningless, because the probe function never enables
> the device's dedicated regulator.
>
> Once the call to cc2_disable() is dropped, the error paths can directly
> return dev_err_probe() in all cases.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2024-08-13 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 22:59 [PATCH v2] hwmon: chipcap2: drop cc2_disable() in the probe and return dev_err_probe() Javier Carrasco
2024-08-13 15:53 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95a73570-0ea9-4396-866e-ffb6fc8a2ba0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox