From: Krzysztof Kozlowski <krzk@kernel.org>
To: peiyu li <579lpy@gmail.com>, jdelvare@suse.com
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: hwmon: lm87: convert to YAML
Date: Sat, 28 Oct 2023 16:58:03 +0200 [thread overview]
Message-ID: <99a72af9-272b-4971-9eaf-64a171b59eb7@kernel.org> (raw)
In-Reply-To: <CAELPsEZV2rgt7M_UxyhB-QZ+TWcYjgi_PORO9Tk4Lofp2AFTmw@mail.gmail.com>
On 28/10/2023 13:59, peiyu li wrote:
>>
>> On 28/10/2023 10:20, Li peiyu wrote:
>>> Convert the lm87 hwmon sensor bindings to DT schema
>>>
>>> Signed-off-by: Li peiyu <579lpy@gmail.com>
>>> ---
>>> Changes for v3:
>>> - add type definition of has-temp3, has-in6, has-in7
>>> - Change the description of has-temp3
>>> Changes for v2:
>>> - replace node name lm87 with sensor
>>> - replace character '\t' with spaces
>>>
>>> .../devicetree/bindings/hwmon/lm87.txt | 30 ---------
>>> .../devicetree/bindings/hwmon/lm87.yaml | 62 +++++++++++++++++++
>>
>> Nothing improved.
>>
>> Stop ignoring feedback. You must respond to it or implement it.
>>
>> Best regards,
>> Krzysztof
>>
> I'm so sorry for that.For v3 I just run make dt_binding_check and forget to
You even removed my address when replying this!
> run checkpatch.pl,resulting in not finding an extra space.Now running the
> dt_binding_check on my computer will cause an error regarding the
> ti,ds90ub960.yaml
> file when I specify the file to be checked as lm87.yaml. This error will occur
> even if I specify other files, I am not sure if it will have an
> impact.I'll submit
> v4.If there are still issues,please tell me the reason again.Sorry again.
v4 did not improve. Please explain me carefully how did you implement
these two feedbacks from first version, so 25th of Oct:
> Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC.
> Also, please use filename like compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-28 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 7:30 [PATCH] dt-bindings: hwmon: lm87: Convert to dtschema Li peiyu
2023-10-25 8:44 ` Krzysztof Kozlowski
2023-10-26 8:02 ` [PATCH v2] dt-bindings: hwmon: lm87: convert to YAML Li peiyu
2023-10-26 13:09 ` Rob Herring
2023-10-27 8:02 ` Krzysztof Kozlowski
2023-10-28 8:20 ` [PATCH v3] " Li peiyu
2023-10-28 8:45 ` Krzysztof Kozlowski
2023-10-28 11:59 ` peiyu li
2023-10-28 14:58 ` Krzysztof Kozlowski [this message]
2023-10-29 8:55 ` peiyu li
2023-10-28 12:05 ` [PATCH v4] " Li peiyu
2023-10-28 14:59 ` Krzysztof Kozlowski
2023-10-28 15:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a72af9-272b-4971-9eaf-64a171b59eb7@kernel.org \
--to=krzk@kernel.org \
--cc=579lpy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox