Re: [PATCH] hwmon: (spd5118) Explicitly enable temperature sensor in probe function

["Kurt Borja" <kuurtb@gmail.com>]

On Tue Feb 3, 2026 at 2:49 PM -05, Guenter Roeck wrote:
> On 2/3/26 11:23, Kurt Borja wrote:
>> On Sat Jan 31, 2026 at 10:20 AM -05, Guenter Roeck wrote:
>>> Instantiating the driver does not make sense if the temperature sensor
>>> is disabled, so enable it unconditionally in the probe function.
>>>
>>> If that fails, write operations to the chip are likely disabled
>>> by the I2C controller. Bail out with an error message if that happens.
>> 
>> Hi Guenter,
>> 
>> As I mentiond in the other thread, after applying this patch the probe
>> fails
>> 
>> 	spd5118 17-0051: error -ENXIO: Failed to enable temperature sensor (write protected ?)
>> 	spd5118 17-0053: error -ENXIO: Failed to enable temperature sensor (write protected ?)
>> 
>> This would be a regression in my platform because, even though the
>> register is write protected, I can still get temperature readings just
>> fine (even after the resume error).
>> 
>
> Yes, but after the next BIOS update it might not work anymore, and
> it is impossible to suspend the system. On top of that, it instantiates
> the spd eeprom which can not really be accessed because that code _does_
> need to write into the chip.
>
> There is no safe way for a spd5118 compliant chip to be accessed reliably
> with write protection active. There is nothing we can do about that.
>
> Guenter

I see... I had the module blacklisted anyway :P but I can imagine future
regression reports.

Thanks for the explaination!

-- 
Thanks,
 ~ Kurt