public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: "Guy Boldon" <gb@guyboldon.com>
To: "Guenter Roeck" <linux@roeck-us.net>,
	"Guy Boldon" <gb@guyboldon.com>, <linux-hwmon@vger.kernel.org>
Cc: <W_Armin@gmx.de>, <jan.claussen10@web.de>
Subject: Re: Weird Dell SMM bug since 6.18
Date: Sun, 22 Mar 2026 11:18:49 +0100	[thread overview]
Message-ID: <DH98GAR01T3A.2T18C7CAX3Q0Q@guyboldon.com> (raw)
In-Reply-To: <c25f34cb-6069-42c4-a7af-bca27c6a411f@roeck-us.net>

Hi Guenter,

Thank you for the explanations, much appreciated. 


On Thu Mar 19, 2026 at 4:52 PM CET, Guenter Roeck wrote:
> The use of -ENODATA in hwmon to report that a value is not available is
> relatively new and isn't even fully documented in the sysfs ABI (admittedly
> a major oversight). The major driver for its use is that it more accurately
> reflects reality as reported by the "sensors" command if an attribute value
> is not available (sensors reports "N/A" instead of an error message if it
> gets an -ENODATA error).

Ah, it seemed somewhat new and that makes sense. -ENODATA converts to
a clean N/A without an error message. We will adjust to handle -ENODATA 
going forward.

>> As a related point: gpd_fan returns -EOPNOTSUPP rather than -ENODATA
>> when in auto mode, and documents that behavior in the kernel docs. The
>
> Please feel free to submit a patch to fix that.

I'll submit a patch for that.

> The best we can do is to find a means to improve consistency, but as you
> can see here even that is difficult because different people will have
> different opinions on how that consistency should look like. Error response
> will vary, as will attribute visibility.
>
> If you would like to get actively involved, please feel free to submit patches
> improving the documentation (Documentation/hwmon/sysfs-interface.rst,
> Documentation/ABI/testing/sysfs-class-hwmon, and or driver specific
> documentation) as well as driver patches to help improve consistency across
> drivers.

I agree and I would like to help improve consistency for the interface. I'll
look at the docs as well. CoolerControl is a direct consumer of this interface
across a large range of drivers, but improving consistency, I think, benefits 
anyone interacting with more than a handful of drivers.

Thanks again,
Guy


  reply	other threads:[~2026-03-22 10:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 12:39 Weird Dell SMM bug since 6.18 Jan Claußen
2026-03-13 16:43 ` Guenter Roeck
2026-03-13 19:06   ` Jan Claußen
2026-03-13 23:10     ` Armin Wolf
2026-03-16 15:52       ` Guenter Roeck
2026-03-16 20:10         ` Jan Claußen
2026-03-17  0:55           ` Guenter Roeck
2026-03-17  1:29             ` Armin Wolf
2026-03-19  9:49               ` Guy Boldon
2026-03-19 15:52                 ` Guenter Roeck
2026-03-22 10:18                   ` Guy Boldon [this message]
2026-03-23 10:25                     ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH98GAR01T3A.2T18C7CAX3Q0Q@guyboldon.com \
    --to=gb@guyboldon.com \
    --cc=W_Armin@gmx.de \
    --cc=jan.claussen10@web.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox