From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Content-Type: multipart/alternative; boundary="Apple-Mail=_BDEB1BAA-0DDF-404E-9341-07C0160E750D" Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] k10temp support for AMD Ryzen w/ Vega gfx From: =?iso-8859-1?Q?Ren=E9_Rebe?= In-Reply-To: <20180305230350.GA13099@roeck-us.net> Date: Tue, 6 Mar 2018 07:48:25 +0100 Cc: linux-hwmon@vger.kernel.org, Clemens Ladisch , linux-kernel@vger.kernel.org Message-Id: References: <1769691A-DD1D-4641-B7BA-62C1BA571EBF@exactcode.de> <20180305230350.GA13099@roeck-us.net> To: Guenter Roeck List-ID: --Apple-Mail=_BDEB1BAA-0DDF-404E-9341-07C0160E750D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 Hi, On 06 Mar 2018, at 00:03, Guenter Roeck wrote: > On Mon, Mar 05, 2018 at 11:38:24PM +0100, Ren=E9 Rebe wrote: >> Hi, >>=20 >> This enables k10temp for the new AMD Ryzen APUs w/ Vega Mobile Gfx. >> Tested on Ryzen 5 2500U, the temperature looked plausible. >>=20 >> Signed-off-by: Ren=E9 Rebe >>=20 >> PS: 1st RFC - might get white-space damaged, will resend when ACKed. >> Sorry my Xemacs/Mew broke. >>=20 >> --- linux-4.15/drivers/hwmon/k10temp.c.vanilla 2018-03-05 = 22:22:30.974331180 +0000 >> +++ linux-4.15/drivers/hwmon/k10temp.c 2018-03-05 = 22:24:17.186327291 +0000 >> @@ -40,6 +40,10 @@ >> #define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463 >> #endif >>=20 >> +#ifndef PCI_DEVICE_ID_AMD_17H_RR_NB >> +#define PCI_DEVICE_ID_AMD_17H_RR_NB 0x15d0 >> +#endif >> + >> /* CPUID function 0x80000001, ebx */ >> #define CPUID_PKGTYPE_MASK 0xf0000000 >> #define CPUID_PKGTYPE_F 0x00000000 >> @@ -89,6 +93,8 @@ >> { 0x17, "AMD Ryzen Threadripper 1950", 10000 }, >> { 0x17, "AMD Ryzen Threadripper 1920", 10000 }, >> { 0x17, "AMD Ryzen Threadripper 1910", 10000 }, >> + { 0x17, "AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx", 20000 = }, >> + { 0x17, "AMD Ryzen 7 2700U with Radeon Vega Mobile Gfx", 20000 = }, >=20 > Do you have a confirmation that the temperature offset is correct ? I tried all of the three currently used offsets and this was looked the = most plausible. For me having some indication of temperature is better than having none = at all. Maybe some contact at AMD can shed some light on it, too? > Thanks, > Guenter >=20 >> }; >>=20 >> static void read_tempreg_pci(struct pci_dev *pdev, u32 *regval) >> @@ -289,6 +2944,7 @@ >> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_NB_F3) }, >> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) }, >> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_DF_F3) }, >> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_RR_NB) }, >> {} >> }; >> MODULE_DEVICE_TABLE(pci, k10temp_id_table); >>=20 >> --=20 >> ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin >> http://exactcode.com | http://exactscan.com | http://ocrkit.com | = http://t2-project.org | http://rene.rebe.de >> -- >> To unsubscribe from this list: send the line "unsubscribe = linux-hwmon" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin http://exactcode.com | http://exactscan.com | http://ocrkit.com | = http://t2-project.org | http://rene.rebe.de --Apple-Mail=_BDEB1BAA-0DDF-404E-9341-07C0160E750D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=iso-8859-1 Hi,

On 06 Mar 2018, at 00:03, = Guenter Roeck <linux@roeck-us.net> = wrote:

On Mon, Mar 05, 2018 at 11:38:24PM +0100, Ren=E9 Rebe = wrote:
Hi,

This enables k10temp for = the new AMD Ryzen APUs w/ Vega Mobile Gfx.
Tested on Ryzen 5 2500U, = the temperature looked plausible.

 Signed-off-by: Ren=E9 = Rebe <rene@exactcode.de>

PS: = 1st RFC - might get white-space damaged, will resend when = ACKed.
Sorry my Xemacs/Mew broke.

--- = linux-4.15/drivers/hwmon/k10temp.c.vanilla 2018-03-05 22:22:30.974331180 = +0000
+++ linux-4.15/drivers/hwmon/k10temp.c = 2018-03-05 22:24:17.186327291 +0000
@@ -40,6 +40,10 @@
= #define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463
#endif

+#ifndef = PCI_DEVICE_ID_AMD_17H_RR_NB
+#define PCI_DEVICE_ID_AMD_17H_RR_NB = 0x15d0
+#endif
+
/* CPUID function 0x80000001, ebx = */
#define CPUID_PKGTYPE_MASK 0xf0000000
#define = CPUID_PKGTYPE_F = = 0x00000000
@@ -89,6 +93,8 @@
{ 0x17, "AMD Ryzen Threadripper = 1950", 10000 },
{ 0x17, "AMD Ryzen Threadripper = 1920", 10000 },
{ 0x17, "AMD Ryzen Threadripper = 1910", 10000 },
+ { 0x17, "AMD Ryzen 5 2500U with = Radeon Vega Mobile Gfx", 20000 },
+ { 0x17, "AMD Ryzen 7 2700U with = Radeon Vega Mobile Gfx", 20000 },

Do you have a = confirmation that the temperature offset is correct = ?

I tried all of the three currently = used offsets and this was looked the most plausible.
For me = having some indication of temperature is better than having none at = all.
Maybe some contact at AMD can shed some light on it, = too?

Thanks,
Guenter

= };

static void read_tempreg_pci(struct pci_dev *pdev, u32 = *regval)
@@ -289,6 +2944,7 @@
{ PCI_VDEVICE(AMD, = PCI_DEVICE_ID_AMD_16H_NB_F3) },
{ PCI_VDEVICE(AMD, = PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) },
{ PCI_VDEVICE(AMD, = PCI_DEVICE_ID_AMD_17H_DF_F3) },
+ { PCI_VDEVICE(AMD, = PCI_DEVICE_ID_AMD_17H_RR_NB) },
{}
};
= MODULE_DEVICE_TABLE(pci, k10temp_id_table);

--
ExactCODE = GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de
--
To = unsubscribe from this list: send the line "unsubscribe linux-hwmon" = in
the body of a message to majordomo@vger.kernel.orgMore majordomo info at  http://vger.kernel.org= /majordomo-info.html

-- 
 ExactCODE = GmbH, Lietzenburger Str. 42, DE-10789 Berlin
 http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de

= --Apple-Mail=_BDEB1BAA-0DDF-404E-9341-07C0160E750D--