public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Rob Herring <robh@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.com>,
	~okias/devicetree@lists.sr.ht, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] WIP: dt-bindings: arm: hwmon: gpio-fan: Convert txt bindings to yaml
Date: Sun, 10 Oct 2021 23:49:08 +0200	[thread overview]
Message-ID: <W97S0R.8W2XT6A4XCW4@ixit.cz> (raw)
In-Reply-To: <1633894316.403809.3158663.nullmailer@robh.at.kernel.org>




On Sun, Oct 10 2021 at 14:31:56 -0500, Rob Herring <robh@kernel.org> 
wrote:
> On Sat, 09 Oct 2021 12:43:09 +0200, David Heidelberg wrote:
>>  Convert fan devices connected to GPIOs to the YAML syntax.
>> 
>>  Signed-off-by: David Heidelberg <david@ixit.cz>
>>  ---
>>   .../devicetree/bindings/hwmon/gpio-fan.txt    | 41 -----------
>>   .../devicetree/bindings/hwmon/gpio-fan.yaml   | 69 
>> +++++++++++++++++++
>>   2 files changed, 69 insertions(+), 41 deletions(-)
>>   delete mode 100644 
>> Documentation/devicetree/bindings/hwmon/gpio-fan.txt
>>   create mode 100644 
>> Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
>> 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for 
> dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1538743
> 
> 
> fan: 'gpio-fan,speed-map' is a required property
> 	arch/arm/boot/dts/kirkwood-nas2big.dt.yaml
> 	arch/arm/boot/dts/kirkwood-net2big.dt.yaml
This sounds correct.

> 
> gpio-fan: gpio-fan,speed-map: 'anyOf' conditional failed, one must be 
> fixed:
> 	arch/arm/boot/dts/gemini-dlink-dir-685.dt.yaml
> 	arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml
> 
Look like two arrays instead one expected.

> gpio_fan: gpio-fan,speed-map: 'anyOf' conditional failed, one must be 
> fixed:
> 	arch/arm/boot/dts/am57xx-beagle-x15.dt.yaml
> 	arch/arm/boot/dts/am57xx-beagle-x15-revb1.dt.yaml
> 	arch/arm/boot/dts/am57xx-beagle-x15-revc.dt.yaml
Look like two arrays instead one expected.

> 
> gpio-fan: gpio-fan,speed-map: 'oneOf' conditional failed, one must be 
> fixed:
> 	arch/arm/boot/dts/gemini-dlink-dir-685.dt.yaml
> 	arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml
> 
Look like three arrays instead one expected.

> gpio_fan: gpio-fan,speed-map: 'oneOf' conditional failed, one must be 
> fixed:
> 	arch/arm/boot/dts/am57xx-beagle-x15.dt.yaml
> 	arch/arm/boot/dts/am57xx-beagle-x15-revb1.dt.yaml
> 	arch/arm/boot/dts/am57xx-beagle-x15-revc.dt.yaml
> 
Look like two arrays instead one expected.

I can send patches to solve these warnings.

David
> 



  reply	other threads:[~2021-10-10 21:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 10:43 [PATCH] WIP: dt-bindings: arm: hwmon: gpio-fan: Convert txt bindings to yaml David Heidelberg
2021-10-10 19:31 ` Rob Herring
2021-10-10 21:49   ` David Heidelberg [this message]
2021-10-11 18:45     ` Rob Herring
2021-10-19 21:35 ` Rob Herring
2021-10-28 13:52   ` David Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=W97S0R.8W2XT6A4XCW4@ixit.cz \
    --to=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=~okias/devicetree@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox