Re: [PATCH 3/3] Replace for_each_*_bit_from() with for_each_*_bit() where appropriate

Guenter Roeck
2021-06-21T20:17:15Z

On Fri, Jun 18, 2021 at 12:57:35PM -0700, Yury Norov wrote:
> A couple of kernel functions call for_each_*_bit_from() with start
> bit equal to 0. Replace them with for_each_*_bit().
>
> No functional changes, but might improve on readability.
>
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> ---
> arch/x86/kernel/apic/vector.c | 4 ++--
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 ++--
> drivers/hwmon/ltc2992.c | 3 +--

This should be three different patches, one per subsystem.

Guenter

> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index fb67ed5e7e6a..d099ef226f55 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -760,9 +760,9 @@ void __init lapic_update_legacy_vectors(void)
>
> void __init lapic_assign_system_vectors(void)
> {
> - unsigned int i, vector = 0;
> + unsigned int i, vector;
>
> - for_each_set_bit_from(vector, system_vectors, NR_VECTORS)
> + for_each_set_bit(vector, system_vectors, NR_VECTORS)
> irq_matrix_assign_system(vector_matrix, vector, false);
>
> if (nr_legacy_irqs() > 1)
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 4102bcea3341..42ce3287d3be 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1032,7 +1032,7 @@ int etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu, struct seq_file *m)
>
> void etnaviv_gpu_recover_hang(struct etnaviv_gpu *gpu)
> {
> - unsigned int i = 0;
> + unsigned int i;
>
> dev_err(gpu->dev, "recover hung GPU!\n");
>
> @@ -1045,7 +1045,7 @@ void etnaviv_gpu_recover_hang(struct etnaviv_gpu *gpu)
>
> /* complete all events, the GPU won't do it after the reset */
> spin_lock(&gpu->event_spinlock);
> - for_each_set_bit_from(i, gpu->event_bitmap, ETNA_NR_EVENTS)
> + for_each_set_bit(i, gpu->event_bitmap, ETNA_NR_EVENTS)
> complete(&gpu->event_free);
> bitmap_zero(gpu->event_bitmap, ETNA_NR_EVENTS);
> spin_unlock(&gpu->event_spinlock);
> diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c
> index 2a4bed0ab226..7352d2b3c756 100644
> --- a/drivers/hwmon/ltc2992.c
> +++ b/drivers/hwmon/ltc2992.c
> @@ -248,8 +248,7 @@ static int ltc2992_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask
>
> gpio_status = reg;
>
> - gpio_nr = 0;
> - for_each_set_bit_from(gpio_nr, mask, LTC2992_GPIO_NR) {
> + for_each_set_bit(gpio_nr, mask, LTC2992_GPIO_NR) {
> if (test_bit(LTC2992_GPIO_BIT(gpio_nr), &gpio_status))
> set_bit(gpio_nr, bits);
> }