Re: [PATCH 10/14] peci: Add peci-cpu driver

Winiarska, Iwona
2021-07-30T20:14:35Z

On Tue, 2021-07-27 at 13:16 +0200, David Müller (ELSOFT AG) wrote:
> Iwona Winiarska wrote:
>
> > +static const struct peci_device_id peci_cpu_device_ids[] = {
> > +       { /* Haswell Xeon */
> > +               .family = 6,
> > +               .model  = INTEL_FAM6_HASWELL_X,
> > +               .data   = "hsx",
> > +       },
> > +       { /* Broadwell Xeon */
> > +               .family = 6,
> > +               .model  = INTEL_FAM6_BROADWELL_X,
> > +               .data   = "bdx",
> > +       },
> > +       { /* Broadwell Xeon D */
> > +               .family = 6,
> > +               .model  = INTEL_FAM6_BROADWELL_D,
> > +               .data   = "skxd",
>
> I think this should read "bdxd" as "skxd" does not exist in the
> cputemp/dimmtemp drivers.

It should be "bdxd" - I'll fix it in v2.

Thank you
-Iwona