From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FF6C433EF for ; Sun, 12 Sep 2021 15:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 907DD6108F for ; Sun, 12 Sep 2021 15:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230483AbhILPPp (ORCPT ); Sun, 12 Sep 2021 11:15:45 -0400 Received: from mga14.intel.com ([192.55.52.115]:17570 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbhILPPo (ORCPT ); Sun, 12 Sep 2021 11:15:44 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="221136470" X-IronPort-AV: E=Sophos;i="5.85,287,1624345200"; d="scan'208";a="221136470" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2021 08:14:30 -0700 X-IronPort-AV: E=Sophos;i="5.85,287,1624345200"; d="scan'208";a="480974769" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2021 08:14:26 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mPRBX-002xN0-KE; Sun, 12 Sep 2021 18:14:23 +0300 Date: Sun, 12 Sep 2021 18:14:23 +0300 From: Andy Shevchenko To: Denis Pauk Cc: Bernhard Seibold , =?iso-8859-1?B?UORy?= Ekholm , to.eivind@gmail.com, "Artem S . Tashkinov" , Vittorio Roberto Alfieri , Sahan Fernando , Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] hwmon: (nct6775) Support access via Asus WMI Message-ID: References: <20210912110557.41346-1-pauk.denis@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210912110557.41346-1-pauk.denis@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sun, Sep 12, 2021 at 02:05:55PM +0300, Denis Pauk wrote: > Support accessing the NCT677x via Asus WMI functions. > > On mainboards that support this way of accessing the chip, > the driver will usually not work without this option since > in these mainboards, ACPI will mark the I/O port as used. > > @Andy Shevchenko, I have left type of sioreg, in other places > sioreg has same integer type, should I change all occurrences > of usage? > @Guenter Roeck, I have left nct6775_*_set_back() call without > changes as its always called from platform specific callbacks. > > Could you please review? > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807 > Signed-off-by: Denis Pauk > Co-developed-by: Bernhard Seibold > Signed-off-by: Bernhard Seibold > Tested-by: Pär Ekholm > Tested-by: > Tested-by: Artem S. Tashkinov > Tested-by: Vittorio Roberto Alfieri > Tested-by: Sahan Fernando This should go to the actual patch that makes it work (preparatory patches may or may not have all above be listed). As kbuild bot rightfully noted, the series has to be bisectable. Compile time bisectability means: each patch should compile incrementally. And run-time bisectability means: the device should work with each patch applied incrementally. I.o.w. you have to compile and boot kernel as many times as patches in your series + 1 (the clean build of the base). -- With Best Regards, Andy Shevchenko