From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F14C433EF for ; Tue, 8 Feb 2022 11:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349025AbiBHLcs (ORCPT ); Tue, 8 Feb 2022 06:32:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357032AbiBHL2j (ORCPT ); Tue, 8 Feb 2022 06:28:39 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F3CEC03FEF3; Tue, 8 Feb 2022 03:28:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD374B81A4A; Tue, 8 Feb 2022 11:28:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2927C004E1; Tue, 8 Feb 2022 11:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644319711; bh=S/OkajaK//lhGgvpH8Fw06Nx4ATm9sAyJIS5raQ2bvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0ybZeeHBJKmL5e5GBklD/SFNg2ORM9tj6Uo94eWeAyDaZznYCaSGBMNaoKafm9Rx o26RX7aXd2Niprs6HcmE6Xc+k1+wpuIvcCGKjthZfKnrVjNwbyTlR6uWsSW7lg2Sgn rVoqZL/xTG2Nwq7Q4um8qFYpeVKRyLKz3iFMsY8o= Date: Tue, 8 Feb 2022 12:28:29 +0100 From: Greg Kroah-Hartman To: Joel Stanley Cc: Iwona Winiarska , Linux Kernel Mailing List , OpenBMC Maillist , devicetree , linux-aspeed , Linux ARM , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, Rob Herring , Andrew Jeffery , Jean Delvare , Guenter Roeck , Arnd Bergmann , Olof Johansson , Jonathan Corbet , Borislav Petkov , Pierre-Louis Bossart , Tony Luck , Andy Shevchenko , Dan Williams , Randy Dunlap , Zev Weiss , David Muller , Dave Hansen , Billy Tsai Subject: Re: [PATCH v7 07/13] peci: Add sysfs interface for PECI bus Message-ID: References: <20220202144838.163875-1-iwona.winiarska@intel.com> <20220202144838.163875-8-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Tue, Feb 08, 2022 at 11:15:30AM +0000, Joel Stanley wrote: > On Tue, 8 Feb 2022 at 11:08, Greg Kroah-Hartman > wrote: > > > > On Wed, Feb 02, 2022 at 03:48:32PM +0100, Iwona Winiarska wrote: > > > PECI devices may not be discoverable at the time when PECI controller is > > > being added (e.g. BMC can boot up when the Host system is still in S5). > > > Since we currently don't have the capabilities to figure out the Host > > > system state inside the PECI subsystem itself, we have to rely on > > > userspace to do it for us. > > > > > > In the future, PECI subsystem may be expanded with mechanisms that allow > > > us to avoid depending on userspace interaction (e.g. CPU presence could > > > be detected using GPIO, and the information on whether it's discoverable > > > could be obtained over IPMI). > > > Unfortunately, those methods may ultimately not be available (support > > > will vary from platform to platform), which means that we still need > > > platform independent method triggered by userspace. > > > > > > Signed-off-by: Iwona Winiarska > > > --- > > > Documentation/ABI/testing/sysfs-bus-peci | 16 +++++ > > > drivers/peci/Makefile | 2 +- > > > drivers/peci/core.c | 3 +- > > > drivers/peci/device.c | 1 + > > > drivers/peci/internal.h | 5 ++ > > > drivers/peci/sysfs.c | 82 ++++++++++++++++++++++++ > > > 6 files changed, 107 insertions(+), 2 deletions(-) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-peci > > > create mode 100644 drivers/peci/sysfs.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-peci b/Documentation/ABI/testing/sysfs-bus-peci > > > new file mode 100644 > > > index 000000000000..56c2b2216bbd > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-peci > > > @@ -0,0 +1,16 @@ > > > +What: /sys/bus/peci/rescan > > > +Date: July 2021 > > > +KernelVersion: 5.15 > > > > 5.15 was a long time ago :( > > > > > > Other than this nit, these all look semi-sane to me. What tree are you > > wanting these to go through, mine? If so, can you fix this up (both > > places in this file) and resend? > > Yes, I recommend Iwona send these through your tree. > > Thanks for taking another look over them. Thanks to Iwona and Intel > for doing this work. Can you provide an ack or reviewed-by for them when they are reposted so I know this? thanks, greg k-h