Re: [PATCH 0/8] Add support for ADT7481 in lm90

[Slawomir Stepien <sst@poczta.fm>]

On maj 20, 2022 09:01, Guenter Roeck wrote:
> On 5/20/22 06:45, Guenter Roeck wrote:
> > On 5/20/22 02:32, Slawomir Stepien wrote:
> > > From: Slawomir Stepien <slawomir.stepien@nokia.com>
> > > 
> > > This patch series adds support for ADT7481 in lm90.c driver and extends the
> > > device-tree options for it.
> > > 
> > > The ADT7481 is quite similar to MAX6696 (already supported in lm90) so a lot of
> > > code is reused.
> > > 
> > > One major problem in fitting the ADT7481 in lm90.c is the chip detection.
> > > However it seems that the chip has been designed and produced with correct
> > > values at locations: 0xfe (manufactured id) and 0xff (chip id), but this is not
> > > documented in the datasheet.
> > > 
> > 
> > Before we go too far along this route, would you mind using my own patch series
> > as base to implement the devicetree changes ? I had prepared an extensive
> > patch series a while ago, adding not only support for ADT7481 but for
> > several other chips as well, I just never got around to sending it out.
> > 
> 
> I made my lm90 patch series available in branch hwmon-lm90 of
> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> 
> The patches in this series were module tested and tested on real hardware
> with the test scripts at git@github.com:groeck/module-tests.git;
> look for scripts/lm90-real.sh and scripts/lm90.sh.

I will test that out.

If I would be happy with that branch, should I rebase all my changes based on that branch and send
the patches to the lists?

-- 
Slawomir Stepien