From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048D62AD2C for ; Wed, 26 Mar 2025 02:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742957084; cv=none; b=PhZqDV1vnYecHPcYizAuvm4nMyibwmUdt0Izc9lGMvAFktZ8ZmDJET3YCpc9Zif9cYulJa3+Rvzc2swZ6Q4mlK3n6/m9tvhEPmsdIBbY6CiZd5ktUb1BoS62omEjwyd+2ZGgJdRQFXq5DEdc8JWU2SZukyVwpRtMxE7mp/Kzcww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742957084; c=relaxed/simple; bh=XxPAydEN/QVzZOUrNuNHLVqKWZeO4X//CfD2Ek1J4cM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cr10npvHKWODESDc0wdTp6nqKyAfMw0bGWVJK6sqJ7m5KwR6hENHC9E9qK0MPCkwPjN7BnlAVgcjxuIQ66JEYjoBKVMz4SLAKxvYeiGcEgMXx95SvTJRpPXhgNCmZeH1aGKOkIAU1mwIK2F+AM9QvmF2rKLoFvSKAU+EhHObtmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=P7OcQ2UI; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="P7OcQ2UI" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22401f4d35aso132516225ad.2 for ; Tue, 25 Mar 2025 19:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1742957082; x=1743561882; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n+QVNWHqDnDbjGyo3K6bEwTsBkwG4P8ZSV0JdfZxw+I=; b=P7OcQ2UIU6/YhRvZajLQ2lGJ+BFu6eJjusiiC+dBB+2Q9iPdKgxINAg1aux0/YjADx gWm84fj2W/jhJM8TyErWlc6hNBfKOF4etBOn2e/df5LmNzUxJQb5rPP9xwtN2TWwywyH SQ/JxmqNycbWAL26o6KdfFCJiccUAQ8Ia02+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742957082; x=1743561882; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n+QVNWHqDnDbjGyo3K6bEwTsBkwG4P8ZSV0JdfZxw+I=; b=fr+MT6n+Nyx5Np66NPiLWitcyzQZOP6hUJCUuCmc8+PNBrIbPcDUmm8pLetasHWXGM 50DrNszzu2m2Jcc0w7iDs/2fIEn5DV3ZVN9sQ/OYYfSL1l68VVuaZBUTt93zqdiF2gX1 yoNbdMpaOpu11Lix50BM2hPCX4tYsmWoFjdP9eAiAMIFbGPdPqRakJPqyWHwnmvrvTyM 1o6xJR3MAhHxqXYzxlctb92BkFgT0IAMKZte2GV9meie5P4q0w4tp6x7OVGEcbmbN09L S8jFM6gAyIVNCxCNgk+HQnDOvJ5pYWU4nViJIAzVfUItxSuxmCJ6UQDBf4xlKzJx+Kn1 peMA== X-Forwarded-Encrypted: i=1; AJvYcCWjvnI2Fdrr3r4j2qmwpdEJollqebF2+H4pFUoAkf/Ol7EAbRsa/A7nOo/7oF43jK0sVsW3FMrPnfa9pg==@vger.kernel.org X-Gm-Message-State: AOJu0YwhA33MfCcbq9UNrXkZ8qis4NfBMPMIIni1L5uwD6gQ45h3FPW1 ZJc/jgJl8MtamzatNNAh2rX8Hdaebil7TvbGGXqAMXoaL0OZiOzEYzobeNpmvQ== X-Gm-Gg: ASbGncu4rGIcZmPqbGi0pyvlo9gLPKpaax1yGOQlss+9/D05sd/b9a6XGPZmh6WGx2a 1xH93tLodjGxcQAZ52V2nAoD1ZB2s3L7DXl4Ya29rZXrLoJGwlQV9dTPckZLZnRhSDgNiCp3GRh R+dxbVxAb4hgIcar1kHZ8Bp7jazNqKXVMIqb37U2gFAyTqdkFYmNge4sxc7u/oovZB4oH9wGvDP vXHCd0Ra7KUAB6H5d3BMiilK1QTVYyztDKr08X+Irh4yWN63rjEj2znzpQWGqleP++VQOgHdWAk 5p3R3VIbr0YcV/PM1RrZdMyCrXeWUp0VkH269wMEVCO72xJaqUb1f0SPW2TDYleNrgXxc6rzxKW HjY0dlGl40+GANwGIjiSWev4= X-Google-Smtp-Source: AGHT+IF5YnTVm0OKmRRmeSaZC9AvdQvm4Gu8QZGPFptt8d07uMe5+ho57hgYCPcyGlZxhVtV7UesPw== X-Received: by 2002:a17:902:d504:b0:215:bc30:c952 with SMTP id d9443c01a7336-22780c68a03mr259297625ad.6.1742957082124; Tue, 25 Mar 2025 19:44:42 -0700 (PDT) Received: from google.com (198.180.199.104.bc.googleusercontent.com. [104.199.180.198]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-227811c156dsm98109075ad.117.2025.03.25.19.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 19:44:41 -0700 (PDT) Date: Wed, 26 Mar 2025 02:44:37 +0000 From: Sung-Chi Li To: Guenter Roeck Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Jean Delvare , Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] hwmon: (cros_ec) Add set and get target fan RPM function Message-ID: References: <20250318-extend_ec_hwmon_fan-v3-1-4c886385861f@chromium.org> <780ce6e8-11fc-42be-b4a7-9cffbf811d78@t-8ch.de> <42c49b0b-cef0-49ca-a5b2-5bb05eae8dec@roeck-us.net> <45d0681d-3446-409c-8d9b-0309dbb93ff8@t-8ch.de> <7b5c4001-1a5b-4ea0-aca9-e0c88ec7a98b@roeck-us.net> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 25, 2025 at 05:55:07AM -0700, Guenter Roeck wrote: > On 3/25/25 00:16, Sung-Chi Li wrote: > > > > > Currently, when sending the fan control setting to EC, EC will switch to manual > > fan control automatically. When system suspends or shuts down, fans are going > > back to automatic control (based on current EC implementation). > > > > Do you mean the driver should not change the fan control method if there is no > > pwmY_enable implemented, or it is the user that should first explicitly set the > > fan to manualy mode, then the user can specify the desired fan speed? > > The user should first set the fan control method to manual mode. > > Unless I am missing something, setting manual mode means that pwmY_enable does have > to be implemented. > > Note that the suspend/resume behavior is unexpected. The user would assume that the fan > control method is still in the same mode after resume. If resume reverts to automatic mode, > there should be a suspend/resume handler which restores the mode on resume. > > Thanks, > Guenter > Thank you for the clarification, I think it is better to implement some missing EC control points (For 1. getting a fan PWM value, and 2. for getting individual fan target speed) first. After that, I will continue working on this seris. Thanks all for these details that I missed.