Re: [RFC PATCH 5/5] hwmon: (lm75) add I3C support for P3T1755

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

Hi Guenter,

> For the few i3c chips which do happen do be lm75 compatible, we should have
> something like
> 
> struct lm75_i3c_devices {
> 	enum lm75_type type;
> 	const char *name;
> };

Sigh, OK, let's have that info a third time.

> And I think "lm75compatible" is really a terrible hwmon device name ;-).

The series is RFC for a reason :D

> i3c doesn't seem to have any access functions (kernel helpers) similar to i2c,
> other than i3c_device_do_priv_xfers(), so unless those are made available
> I think we'll have to bite the bullet and use local access functions.

Well, yes, there are not many I3C target drivers, so there is no
critical mass for I3C helpers yet. With helpers I meant more convesion
helpers like cpu_to_be16 and the likes. I see them rarely used in hwmon,
so I wondered about this.

> The other patches look good to me. If you send me a Reviewed-by: and/or
> Tested-by: to my patch, I'll queue it all up (except for this patch)
> for 6.14.

Done. Thank you!

All the best,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]