From: Andi Shyti <andi.shyti@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
Badal Nilawar <badal.nilawar@intel.com>,
intel-xe@lists.freedesktop.org, linux-hwmon@vger.kernel.org,
anshuman.gupta@intel.com, ashutosh.dixit@intel.com,
riana.tauro@intel.com, matthew.brost@intel.com
Subject: Re: [PATCH v3 1/6] drm/xe/hwmon: Add HWMON infrastructure
Date: Thu, 3 Aug 2023 01:34:51 +0200 [thread overview]
Message-ID: <ZMroG8SWDMDHtsOL@ashyti-mobl2.lan> (raw)
In-Reply-To: <b863c26d-143b-9dd4-7f90-44a2b0ae94e2@roeck-us.net>
Hi Guenter,
[...]
> > > +static const struct hwmon_channel_info *hwmon_info[] = {
> > > + NULL
> > > +};
> >
> > just:
> >
> > static const struct hwmon_channel_info *hwmon_info[] = { };
> >
> > would do.
> >
>
> What would be the point ? This is just a placeholder, and we need
> a NULL entry at the end.
right... this series needs to be read from the end to the
beginning :)
Andi
next prev parent reply other threads:[~2023-08-02 23:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 13:52 [PATCH v3 0/6] Add HWMON support for DGFX Badal Nilawar
2023-08-02 13:52 ` [PATCH v3 1/6] drm/xe/hwmon: Add HWMON infrastructure Badal Nilawar
2023-08-02 14:15 ` Guenter Roeck
2023-08-02 22:40 ` Andi Shyti
2023-08-02 23:11 ` Guenter Roeck
2023-08-02 23:34 ` Andi Shyti [this message]
2023-08-03 0:06 ` Guenter Roeck
2023-08-02 23:12 ` Guenter Roeck
2023-08-04 13:19 ` Nilawar, Badal
2023-08-04 14:26 ` Guenter Roeck
2023-08-04 14:36 ` Nilawar, Badal
2023-08-08 21:31 ` [Intel-xe] " Rodrigo Vivi
2023-08-08 22:07 ` Guenter Roeck
2023-08-11 16:01 ` Rodrigo Vivi
2023-08-11 17:39 ` Guenter Roeck
2023-08-11 18:48 ` Rodrigo Vivi
2023-08-04 14:43 ` Nilawar, Badal
2023-08-04 13:25 ` Nilawar, Badal
2023-08-02 13:52 ` [PATCH v3 2/6] drm/xe/hwmon: Expose power attributes Badal Nilawar
2023-08-02 23:23 ` Andi Shyti
2023-08-04 14:21 ` Nilawar, Badal
2023-08-02 13:52 ` [PATCH v3 3/6] drm/xe/hwmon: Expose card reactive critical power Badal Nilawar
2023-08-02 23:28 ` Andi Shyti
2023-08-04 13:31 ` Nilawar, Badal
2023-08-02 13:52 ` [PATCH v3 4/6] drm/xe/hwmon: Expose input voltage attribute Badal Nilawar
2023-08-02 23:32 ` Andi Shyti
2023-08-04 13:30 ` Nilawar, Badal
2023-08-02 13:52 ` [PATCH v3 5/6] drm/xe/hwmon: Expose hwmon energy attribute Badal Nilawar
2023-08-02 14:14 ` Guenter Roeck
2023-08-03 6:34 ` Nilawar, Badal
2023-08-03 14:42 ` Guenter Roeck
2023-08-02 13:52 ` [PATCH v3 6/6] drm/xe/hwmon: Expose power1_max_interval Badal Nilawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMroG8SWDMDHtsOL@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthew.brost@intel.com \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox