From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Tremblay <etremblay@distech-controls.com>,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 2/3] hwmon: tmp513: Simplify with dev_err_probe()
Date: Fri, 1 Dec 2023 15:53:08 +0200 [thread overview]
Message-ID: <ZWnlRAOG7EP3RyPR@smile.fi.intel.com> (raw)
In-Reply-To: <1ef66c53-d9ba-4fca-8462-b670f029f5de@roeck-us.net>
On Thu, Nov 30, 2023 at 08:10:12PM -0800, Guenter Roeck wrote:
> On Tue, Nov 28, 2023 at 08:06:03PM +0200, Andy Shevchenko wrote:
> > Common pattern of handling deferred probe can be simplified with
> > dev_err_probe(). Less code and also it prints the error value.
...
> > + if (IS_ERR(data->regmap))
> > + return dev_err_probe(dev, PTR_ERR(data->regmap), "failed to allocate register map\n");
>
> That line length was getting too long. Please consider running checkpatch
> on your patches.
I got your point, but checkpatch has no limit for the string literals, see
f4c014c0dede ("checkpatch: allow printk strings to exceed 80 characters to maintain their searchability")
ca56dc098caf ("checkpatch: check for quoted strings broken across lines")
So, what the exact parameters should I supply to it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-01 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 18:06 [PATCH v1 0/3] hwmon: tmp513: A few cleanups Andy Shevchenko
2023-11-28 18:06 ` [PATCH v1 1/3] hwmon: tmp513: Don't use "proxy" headers Andy Shevchenko
2023-12-01 4:07 ` Guenter Roeck
2023-11-28 18:06 ` [PATCH v1 2/3] hwmon: tmp513: Simplify with dev_err_probe() Andy Shevchenko
2023-12-01 4:10 ` Guenter Roeck
2023-12-01 13:53 ` Andy Shevchenko [this message]
2023-12-01 14:51 ` Guenter Roeck
2023-12-01 15:08 ` Andy Shevchenko
2023-11-28 18:06 ` [PATCH v1 3/3] hwmon: tmp513: Use SI constants from units.h Andy Shevchenko
2023-12-01 4:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWnlRAOG7EP3RyPR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=etremblay@distech-controls.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox