From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (ltc2992) use fwnode_for_each_available_child_node_scoped()
Date: Wed, 22 May 2024 14:37:35 +0300 [thread overview]
Message-ID: <Zk3Y_5B8lR0wHpD8@smile.fi.intel.com> (raw)
In-Reply-To: <20240522-fwnode_for_each_available_child_node_scoped-v1-2-1188b0da12dc@gmail.com>
On Wed, May 22, 2024 at 11:18:08AM +0200, Javier Carrasco wrote:
> The error path from a zero value of the "shunt-resistor-micro-ohms"
> property does not decrement the refcount of the child node.
>
> Instead of adding the missing fwnode_handle_put(), a safer fix for
> future modifications is using the _scoped version of the macro,
> which removes the need for fwnode_handle_put() in all error paths.
Not sure if the fix for easier backporting is better, up to Guenter and Greg.
If the above is the case, you will need
1) backportable fix;
2) the patch 1 as of this series;
3) conversion patch.
> The macro defines the child node internally, which removes the need for
> the current child node declaration as well.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
in case it will go the current way.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-22 11:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 9:18 [PATCH 0/2] device property: introduce fwnode_for_each_available_child_node_scoped() Javier Carrasco
2024-05-22 9:18 ` [PATCH 1/2] " Javier Carrasco
2024-05-22 11:34 ` Andy Shevchenko
2024-05-22 11:45 ` Sakari Ailus
2024-05-22 9:18 ` [PATCH 2/2] hwmon: (ltc2992) use fwnode_for_each_available_child_node_scoped() Javier Carrasco
2024-05-22 11:37 ` Andy Shevchenko [this message]
2024-05-22 19:08 ` Guenter Roeck
2024-05-22 19:46 ` Javier Carrasco
2024-05-22 22:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk3Y_5B8lR0wHpD8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=antoniu.miclaus@analog.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox