From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 2/6] hwmon: (max6697) Drop platform data support
Date: Tue, 23 Jul 2024 05:37:11 +0000 [thread overview]
Message-ID: <Zp9Bh4JgGJX3yhV6@google.com> (raw)
In-Reply-To: <20240723005204.1356501-3-linux@roeck-us.net>
On Mon, Jul 22, 2024 at 05:52:00PM -0700, Guenter Roeck wrote:
> +static int max6697_config_of(struct max6697_data *data, struct i2c_client *client)
> {
[...]
> - pdata->smbus_timeout_disable =
> - of_property_read_bool(node, "smbus-timeout-disable");
> - pdata->extended_range_enable =
> - of_property_read_bool(node, "extended-range-enable");
> - pdata->beta_compensation =
> - of_property_read_bool(node, "beta-compensation-enable");
> + confreg = 0;
> + if (of_property_read_bool(node, "smbus-timeout-disable") &&
> + (data->chip->valid_conf & MAX6697_CONF_TIMEOUT)) {
s/data->chip/chip/.
> + if (data->type == max6581) {
Should be `data->type != max6581`.
next prev parent reply other threads:[~2024-07-23 5:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 0:51 [PATCH 0/6] hwmon: (max6697) Cleanup, use regmap and with_info API Guenter Roeck
2024-07-23 0:51 ` [PATCH 1/6] hwmon: (max6697) Reorder include files Guenter Roeck
2024-07-23 5:36 ` Tzung-Bi Shih
2024-07-23 14:16 ` Guenter Roeck
2024-07-23 0:52 ` [PATCH 2/6] hwmon: (max6697) Drop platform data support Guenter Roeck
2024-07-23 5:37 ` Tzung-Bi Shih [this message]
2024-07-23 14:20 ` Guenter Roeck
2024-07-23 14:48 ` Guenter Roeck
2024-07-23 0:52 ` [PATCH 3/6] hwmon: (max6697) Use bit operations where possible Guenter Roeck
2024-07-23 5:37 ` Tzung-Bi Shih
2024-07-23 14:24 ` Guenter Roeck
2024-07-23 0:52 ` [PATCH 4/6] hwmon: (max6697) Convert to use regmap Guenter Roeck
2024-07-23 5:37 ` Tzung-Bi Shih
2024-07-23 0:52 ` [PATCH 5/6] hwmon: (max6697) Convert to with_info hwmon API Guenter Roeck
2024-07-23 5:37 ` Tzung-Bi Shih
2024-07-23 0:52 ` [PATCH 6/6] hwmon: (max6697) Add support for tempX_min and tempX_min_alarm Guenter Roeck
2024-07-23 5:37 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp9Bh4JgGJX3yhV6@google.com \
--to=tzungbi@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox